Use path instead of individually hard coded commands #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- only 1 'local' method Distros.local - don't 'exist' on a release_file that doesn't exist - consistent stubbing of distro.
- move package distro case statement into distro itself - remove redhat distro constant (it is rhel or fedora) - leverage Distros.all instead of meta class fu
|
|
spec/etc_issue_spec.rb
Outdated
There was a problem hiding this comment.
Would flip this to be expect(subject).to include("phrase")
- remove knowledge of internals from specs - lazy load file - add include? method
|
Checked commits kbrock@ae44751 .. kbrock@3b0f239 with rubocop Everything looks good. 👍 |
Fryguy
added a commit
that referenced
this pull request
Apr 1, 2014
Use path instead of individually hard coded commands
Fryguy
added a commit
to Fryguy/linux_admin
that referenced
this pull request
Jul 10, 2014
Specifically commit c99c63b Previously Rpm < Package < LinuxAdmin, and LinuxAdmin is where the .run method comes from. By removing Package, Rpm broke by not having access to .run. This readds the class to fix that issue.
Fryguy
added a commit
to Fryguy/linux_admin
that referenced
this pull request
Jul 10, 2014
Specifically commit c99c63b Previously Rpm < Package < LinuxAdmin, and LinuxAdmin is where the .run method comes from. By removing Package, Rpm broke by not having access to .run. This readds the class to fix that issue.
Fryguy
added a commit
to Fryguy/linux_admin
that referenced
this pull request
Jul 10, 2014
Specifically commit c99c63b Previously Rpm < Package < LinuxAdmin, and LinuxAdmin is where the .run method comes from. By removing Package, Rpm broke by not having access to .run. This readds the class to fix that issue.
jrafanie
added a commit
that referenced
this pull request
Jul 10, 2014
Readd Package abstract class that was removed in #96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Fryguy
I understand we used to use the system PATH, but it had too many special cases and code around such a simple lookup. Using an internal PATH (much the way system daemons like cron and ssh do) seemed like a simpler and more resilient approach.
In order to do this, I needed to do some cleanup, so this PR took on a life of its own.
@jrafanie: let me know where you want me to split up the code into multiple PRs. As always, the commits represent the different blocks of work I performed.
Oh, and @jrafanie, it would have been delta -111 lines, but I added 45 lines in new specs. Let them eat 🍰!
UPDATE:
Notes on implementation:
Distros::Distro.localandDistors.local, with more consistent rspec stubs.Packagecase statement in favor of inheritence inDistroDistros.redhatin favor ofrhel,fedoraand leveragedDistros.allinstead of meta class fuDistrosubclasses (e.g.:RedHat,Fedora), just useDistroinstead.Distroconstants likeCOMMANDSand just used instance variables instead. (aside: Something odd was happening withRELEASE_FILE)