Mac support #151
Closed
Mac support #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
mac_support
branch
2 times, most recently
from
29a3dc7 to
f075581
Compare
|
Looks like brew install iproute2macSo I guess this is not needed - but not standard. Would you prefer me to continue on this PR, or we'll just go the |
|
Checked commits kbrock/linux_admin@5f9d2b9~...61f243c with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
There was a problem hiding this comment.
Maybe this can all be:
case(Distros.local)
when Distros.rhel, Distros.fedora
NetworkInterfaceRH
when Distros.mac
NetworkInterfaceMac
else
NetworkInterfaceGeneric
endI think it's nicer than the array include followed by ==
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Fryguy @carbonin I want to run
appliance_consoleon my mac.While I made the ip and gateway methods work, it really isn't necessary. I just want to be able to run the various menu options.
/cc @jrafanie @gtanzillo FYI