Skip to content

Conversation

jrafanie
Copy link
Member

Fixed by 6a75513
Fixes #22

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9af2145 on jrafanie:verify_pathname_in_option_values into 8dbd565 on ManageIQ:master.

@Fryguy
Copy link
Member

Fryguy commented Aug 23, 2013

Should we also handle pathname objects in the cmd variable to run?

@jrafanie
Copy link
Member Author

@Fryguy It should work. The cmd is interpolated here (https://github.com/ManageIQ/linux_admin/blob/master/lib/linux_admin/common.rb#L66) so it should just work if it's a Pathname. The issue this spec confirms is fixed is that we called shellescape on the Pathname object here previously: 6a75513#L0L49

I can add another example with a cmd variable for further confirmation but I think we're all good.

@Fryguy
Copy link
Member

Fryguy commented Aug 24, 2013

Yeah, maybe we should add another spec to show that we support it, especially if a refactoirng comes in the future.

@jrafanie
Copy link
Member Author

@Fryguy Closing this pull request as your comment about Pathname support for commands reveals a bug I'll fix separately.

@jrafanie jrafanie closed this Aug 26, 2013
@jrafanie jrafanie mentioned this pull request Aug 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LinuxAdmin.run should handle Pathname objects in the params

3 participants