Fix Pathname support #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Is this backwards? The key part of a key/value pair is the command line option itself (the "--whatever") Does it make sense to have a path name on the key side?
There was a problem hiding this comment.
@Fryguy This example is contrived but I could see you running:
LinuxAdmin.run("/bin/some_script.sh", :params => {"/usr/bin/ruby" => nil})If you wanted to use a Pathname instead of a String and it's not coming from user input, then I can imagine wanting to do this.
There was a problem hiding this comment.
@Fryguy what do you think?
There was a problem hiding this comment.
@jrafanie yeah, I think it's an ok test, although it is contrived, like you said. Basically, we are showing we can support anything as a key parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened as a followup to #41 since Pathnames were not supported in commands with no parameters and when used a parameter options.