raise an error when a command is not defined #94
Conversation
spec/disk_spec.rb
Outdated
There was a problem hiding this comment.
Since this is being done everywhere, does it make sense to stub in a global before in the spec_helper...e.g.
RSpec.configure do |config|
config.before do
stub_distro
end
end
|
Checked commit kbrock@ad5cdee with rubocop This comment is on an outdated set of commits. |
spec/common_spec.rb
Outdated
|
@Fryguy Do we even want this to raise errors? |
|
Checked commit kbrock@3fd65ca with rubocop This comment is on an outdated set of commits. |
The various operating systems have defined specific commands. When it is not found on a particular OS, then the error message is confusing - better stubbing support
|
Checked commit kbrock@3747f89 with rubocop Everything looks good. 👍 |
|
This pull request is not mergeable. Please rebase and repush. |
|
Errors aren't going to creep up like before if we use |
3 participants
When the os can't be found, we tend to get '--arg' is not a valid command.
This raises an exception to say that the command is not found.
issue: not sure the best way to communicate this with the calling app.