Add ruff rules PERF for performance

Author: cclauss

.pre-commit-config.yaml

@@ -12,17 +12,26 @@ repos:
       - id: end-of-file-fixer
       - id: check-toml
         name: Validate pyproject.toml
+
+  - repo: https://github.com/codespell-project/codespell
+    rev: v2.4.1
+    hooks:
+      - id: codespell
+        files: ^.*\.(py|md|rst)$
+        args: ["-L", "medias,nam"]
+
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.14.6
+    rev: v0.14.7
     hooks:
       - id: ruff
         name: ruff lint
         types: [python]
         args: [--exit-non-zero-on-fix]
       - id: ruff-format
         types: [python]
+
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.18.2
+    rev: v1.19.0
     hooks:
       - id: mypy
         additional_dependencies:
@@ -34,10 +43,3 @@ repos:
             types-setuptools,
           ]
         files: ^manim/
-
-  - repo: https://github.com/codespell-project/codespell
-    rev: v2.4.1
-    hooks:
-      - id: codespell
-        files: ^.*\.(py|md|rst)$
-        args: ["-L", "medias,nam"]

manim/cli/init/commands.py

@@ -43,11 +43,9 @@ def select_resolution() -> tuple[int, int]:
     tuple[int, int]
         Tuple containing height and width.
     """
-    resolution_options: list[tuple[int, int]] = []
-    for quality in QUALITIES.items():
-        resolution_options.append(
-            (quality[1]["pixel_height"], quality[1]["pixel_width"]),
-        )
+    resolution_options: list[tuple[int, int]] = [
+        (quality[1]["pixel_height"], quality[1]["pixel_width"]) for quality in QUALITIES.items()
+    ]
     resolution_options.pop()
     choice = click.prompt(
         "\nSelect resolution:\n",

manim/mobject/geometry/boolean_ops.py

@@ -182,9 +182,7 @@ def __init__(self, *vmobjects: VMobject, **kwargs: Any) -> None:
         if len(vmobjects) < 2:
             raise ValueError("At least 2 mobjects needed for Union.")
         super().__init__(**kwargs)
-        paths = []
-        for vmobject in vmobjects:
-            paths.append(self._convert_vmobject_to_skia_path(vmobject))
+        paths = [self._convert_vmobject_to_skia_path(vmobject) for vmobject in vmobjects]
         outpen = SkiaPath()
         union(paths, outpen.getPen())
         self._convert_skia_path_to_vmobject(outpen)

manim/mobject/graph.py

@@ -1021,10 +1021,7 @@ def _add_edge(
         """
         if edge_config is None:
             edge_config = self.default_edge_config.copy()
-        added_mobjects = []
-        for v in edge:
-            if v not in self.vertices:
-                added_mobjects.append(self._add_vertex(v))
+        added_mobjects = [self._add_vertex(v) for v in edge if v not in self.vertices]
         u, v = edge
 
         self._graph.add_edge(u, v)

manim/mobject/mobject.py

@@ -2959,8 +2959,7 @@ def add_n_more_submobjects(self, n: int) -> Self | None:
         new_submobs = []
         for submob, sf in zip(self.submobjects, split_factors):
             new_submobs.append(submob)
-            for _ in range(1, sf):
-                new_submobs.append(submob.copy().fade(1))
+            new_submobs.extend(submob.copy().fade(1) for _ in range(1, sf))
         self.submobjects = new_submobs
         return self
 

manim/mobject/three_d/polyhedra.py

@@ -154,9 +154,7 @@ def extract_face_coords(self) -> Point3DLike_Array:
         """Extracts the coordinates of the vertices in the graph.
         Used for updating faces.
         """
-        new_vertex_coords = []
-        for v in self.graph.vertices:
-            new_vertex_coords.append(self.graph[v].get_center())
+        new_vertex_coords = [self.graph[v].get_center() for v in self.graph.vertices]
         layout = dict(enumerate(new_vertex_coords))
         return [[layout[j] for j in i] for i in self.faces_list]
 

manim/renderer/shader_wrapper.py

@@ -141,10 +141,9 @@ def get_program_code(self):
 
     def replace_code(self, old: str, new: str) -> None:
         code_map = self.program_code
-        for name, _code in code_map.items():
-            if code_map[name] is None:
-                continue
-            code_map[name] = re.sub(old, new, code_map[name])
+        for name, code in code_map.items():
+            if code:
+                code_map[name] = re.sub(old, new, code)
         self.refresh_id()
 
     def combine_with(self, *shader_wrappers: "ShaderWrapper") -> Self:  # noqa: UP037

manim/utils/deprecation.py

@@ -521,10 +521,7 @@ def deprecate_params(func: Callable[..., T], *args: Any, **kwargs: Any) -> T:
             arguments.
 
         """
-        used = []
-        for param in params:
-            if param in kwargs:
-                used.append(param)
+        used = [param for param in params if param in kwargs]
 
         if len(used) > 0:
             logger.warning(warning_msg(func, used))

pyproject.toml

@@ -87,7 +87,7 @@ dev = [
     "pytest>=8.3.4",
     "pytest-cov>=6.0.0",
     "pytest-xdist>=2.2,<3.0",
-    "ruff>=0.9.3",
+    "ruff>=0.14.7",
     "sphinx>=7.4.7",
     "sphinx-copybutton>=0.5.2",
     "sphinx-design>=0.6.1",
@@ -149,13 +149,14 @@ select = [
   "C4",
   "D",
   "E",
-  "W",
   "F",
   "I",
+  "PERF",
   "PGH",
   "PT",
   "SIM",
   "UP",
+  "W",
 ]
 
 ignore = [
@@ -172,18 +173,19 @@ ignore = [
   "D205",
   "D212",
   "D4",
+  "E111",
+  "E114",
+  "E117",
+  "E501",
   # due to the import * used in manim
   "F403",
   "F405",
+  "PERF203",  # try-except-in-loop
   # Exception too broad (this would require lots of changes + re.escape) for little benefit
   "PT011",
   # as recommended by https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules
   "D206",
   "D300",
-  "E111",
-  "E114",
-  "E117",
-  "E501",
 ]
 
 # Allow unused variables when underscore-prefixed.

tests/module/mobject/test_graph.py

@@ -105,11 +105,11 @@ def test_graph_accepts_labeledline_as_edge_type():
         vertices, edges, edge_type=LabeledLine, edge_config=edge_config
     )
 
-    for _edge_key, edge_obj in G_manual.edges.items():
+    for edge_obj in G_manual.edges.values():
         assert isinstance(edge_obj, LabeledLine)
         assert hasattr(edge_obj, "label")
 
-    for _edge_key, edge_obj in G_directed.edges.items():
+    for edge_obj in G_directed.edges.values():
         assert isinstance(edge_obj, LabeledLine)
         assert hasattr(edge_obj, "label")