Skip to content

Conversation

@SASHAKT1290
Copy link
Contributor

Overview: What does this pull request change?

This pull request updates the default rendering resolution in cli/commands.py to 1920x1080.

Motivation and Explanation: Why and how do your changes improve the library?

The Quickstart tutorial currently recommends using manim init project, which creates a manim.cfg file that overrides the default settings, leading to a distorted coordinate system (as reported in #4184)

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Oct 21, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ❌ Rejected in Dev Board Oct 22, 2025
@SASHAKT1290 SASHAKT1290 reopened this Oct 22, 2025
@github-project-automation github-project-automation bot moved this from ❌ Rejected to 📋 Backlog in Dev Board Oct 22, 2025
@SASHAKT1290
Copy link
Contributor Author

@JasonGrace2282
I chagned the init resolution to the default one but failing the pre-commit test even though none of the other codebase has altered.

@SASHAKT1290
Copy link
Contributor Author

@JasonGrace2282 @cclauss
The tests are passing now.
Can you please have a look at the PR?

@henrikmidtiby
Copy link
Contributor

@SASHAKT1290 In the commit 7ffdf04 the order of the values in the tuple was changed to (height, width).
If you reorder the values I would approve the PR.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ❌ Rejected in Dev Board Oct 24, 2025
@henrikmidtiby
Copy link
Contributor

@SASHAKT1290 we usually continue with the same pull request instead of closing and opening a new PR.

Superseeded by #4455

@SASHAKT1290 SASHAKT1290 reopened this Oct 24, 2025
@github-project-automation github-project-automation bot moved this from ❌ Rejected to 📋 Backlog in Dev Board Oct 24, 2025
@henrikmidtiby henrikmidtiby self-requested a review October 24, 2025 19:41
@henrikmidtiby henrikmidtiby added the pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! label Oct 24, 2025
Copy link
Contributor

@henrikmidtiby henrikmidtiby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 👍 To be merged in Dev Board Oct 24, 2025
@SASHAKT1290
Copy link
Contributor Author

@henrikmidtiby sorry for the inconvenience. I have added the same changes to this PR.

@henrikmidtiby henrikmidtiby enabled auto-merge (squash) October 24, 2025 19:42
@behackl behackl disabled auto-merge October 24, 2025 19:56
@behackl behackl merged commit a810f55 into ManimCommunity:main Oct 24, 2025
40 of 55 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Oct 24, 2025
@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants