-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Update default resolution in CLI to match Manim’s 1920x1080 default settings #4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@JasonGrace2282 |
|
@JasonGrace2282 @cclauss |
|
@SASHAKT1290 In the commit 7ffdf04 the order of the values in the tuple was changed to (height, width). |
0886482 to
7ffdf04
Compare
|
@SASHAKT1290 we usually continue with the same pull request instead of closing and opening a new PR. Superseeded by #4455 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for the PR.
|
@henrikmidtiby sorry for the inconvenience. I have added the same changes to this PR. |
Overview: What does this pull request change?
This pull request updates the default rendering resolution in
cli/commands.pyto 1920x1080.Motivation and Explanation: Why and how do your changes improve the library?
The Quickstart tutorial currently recommends using manim init project, which creates a manim.cfg file that overrides the default settings, leading to a distorted coordinate system (as reported in #4184)
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist