Pass ndarrays to mapbox_earcut.triangulate_float32() to fix TypeError in mapbox_earcut==2.0.0
#4479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Change argument passing to the triangulate_float32 method, using an explicitly-created NumPy Array (with dtype=uint32).
becomes
Motivation and Explanation: Why and how do your changes improve the library?
I was having problems trying to use the OpenGL Renderer. I investigated and a simple line fix corrected the behavior.
MWE:
This yields:
When using
mapbox-earcut=2.0.0andmanim=0.19.0Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist