feat: tile cooldown support#5
Merged
melancholiai merged 14 commits intomasterfrom Dec 8, 2024
Merged
Conversation
Contributor
melancholiai
commented
Nov 21, 2024
melancholiai
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✔ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✔ |
| Tests added | ✔ |
| Chore | ✖ |
NivGreenstein
approved these changes
Nov 24, 2024
| (msg: string, ...args: unknown[]): void; | ||
| } | ||
|
|
||
| type BBox = [number, number, number, number]; |
There was a problem hiding this comment.
Use BoundingBox type from geojson package instead
Contributor
Author
There was a problem hiding this comment.
geojson's BBox is either [number, number, number, number] | [number, number, number, number, number, number], I prefer to have more precision
| export const keyfy = (params: TileParamsWithKit): string => `${TILE_DETAILS_KEY_PREFIX}:${params.kit}:${params.z}/${params.x}/${params.y}`; | ||
|
|
||
| export const hashValue = (value: unknown): string => { | ||
| const hash = createHash('md5'); |
There was a problem hiding this comment.
MD5 hash as been proven to be vurnable to a collision attack. We might have to look for another hash function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.