fix: support hebrew characters in feature properties by adding UTF-8 encoding to shapefile reader#43
Merged
Merged
Conversation
…encoding to shapefile reader
There was a problem hiding this comment.
Pull Request Overview
This PR fixes support for Hebrew characters in shapefile feature properties by adding UTF-8 encoding to the shapefile reader. The change ensures that non-ASCII characters in DBF files are properly decoded when reading shapefiles.
- Updated the shapefile reader to use UTF-8 encoding when opening shapefile and DBF files
- Added DBF file path construction for proper encoding support
- Updated corresponding test to verify the new encoding parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/files/shapefile/core/shapeFileReader.ts | Modified to construct DBF path and pass UTF-8 encoding to shapefile.open() |
| tests/unit/files/shapefile/shapeFileReader.spec.ts | Updated test expectations to include DBF path and encoding parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| try { | ||
| const reader = await open(shapefilePath); | ||
| const dbfPath = shapefilePath.replace(/\.shp$/i, '.dbf'); | ||
| //support feature properties with hebrew characters by setting encoding to 'utf-8' |
There was a problem hiding this comment.
[nitpick] The comment should start with a capital letter and end with a period for consistency: '// Support feature properties with Hebrew characters by setting encoding to 'utf-8'.'
Suggested change
| //support feature properties with hebrew characters by setting encoding to 'utf-8' | |
| // Support feature properties with Hebrew characters by setting encoding to 'utf-8'. |
razbroc
reviewed
Sep 11, 2025
CL-SHLOMIKONCHA
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further information:
support hebrew characters in feature properties by adding UTF-8 encoding to shapefile reader