refactor(helm): move OpenTelemetry otelRatioSampler to helpers and update nginx.conf#37
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Helm chart’s OpenTelemetry sampling configuration by moving the split_clients ratio-sampler block into a reusable helper and shifting OpenTelemetry trace configuration to the top-level http {} scope in nginx.conf.
Changes:
- Added a new Helm helper (
nginx.otelRatioSampler) to generate thesplit_clientsratio sampler block. - Updated
helm/config/nginx.confto include the ratio sampler and OpenTelemetry trace configuration withinhttp {}. - Removed the inlined ratio sampler and per-server OpenTelemetry trace include from
helm/config/default.conf.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| helm/templates/_helpers.tpl | Introduces a helper to render the OpenTelemetry ratio sampler split_clients block. |
| helm/config/nginx.conf | Includes the new ratio sampler helper and moves trace configuration into http {}. |
| helm/config/default.conf | Removes the previously inlined sampler block and server-level trace include. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ronenkapelian
previously approved these changes
Apr 12, 2026
CL-SHLOMIKONCHA
previously approved these changes
Apr 13, 2026
shimoncohen
reviewed
Apr 13, 2026
almog8k
dismissed stale reviews from CL-SHLOMIKONCHA and ronenkapelian
via
d9acb1e
shimoncohen
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CL-SHLOMIKONCHA
approved these changes
Apr 15, 2026
Contributor
Author
|
@copilot apply changes based on the comments in this thread |
Copilot stopped work on behalf of
almog8k due to an error
April 15, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.