feat(auth-manager): created package and added openapi#2
Merged
Conversation
syncush
reviewed
Mar 21, 2023
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/connection' |
Contributor
There was a problem hiding this comment.
createdAt is not required here, is it possible ?
Contributor
Author
There was a problem hiding this comment.
it is readonly so it doesn't matter.
syncush
reviewed
Mar 21, 2023
| $ref: '#/components/responses/400BadRequest' | ||
| 404: | ||
| $ref: '#/components/responses/404NotFound' | ||
| /client/{clientName}/connection: |
Contributor
There was a problem hiding this comment.
shouldn't it be connections in plural ?
syncush
reviewed
Mar 21, 2023
| schema: | ||
| $ref: '#/components/schemas/connection' | ||
| responses: | ||
| 201: |
Contributor
There was a problem hiding this comment.
shouldn't we return the connection?
syncush
reviewed
Mar 21, 2023
| schema: | ||
| $ref: '#/components/schemas/key' | ||
| responses: | ||
| 201: |
Contributor
There was a problem hiding this comment.
Another 201 with no content, i really wonder if it should be 204 or 201
syncush
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created the auth-manager package - note that jest run as it used to be, and not for the entire monorepo
created openapi - i thought about removing the patch method for the versioned resources, and just having post act as upsert. WDYT? @syncush