helm(token-kiosk): added helm MAPCO-8239#93
Conversation
CptSchnitz
force-pushed
the
add-token-kiosk-helm
branch
from
4361c73 to
b92be00
Compare
CptSchnitz
changed the title
|
🎫 Related Jira Issue: MAPCO-8239 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds Helm chart support for the token-kiosk service as part of ticket MAPCO-8239. The changes include creating a new Helm chart for token-kiosk and refactoring configuration management across multiple services to use a consistent structure.
- Adds complete Helm chart configuration for token-kiosk service with database, SSL auth, and monitoring support
- Refactors configuration management structure from
configManagementtoconfigManageracross auth services - Integrates mc-labels-and-annotations dependency for consistent labeling
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/token-kiosk/helm/values.yaml | New Helm values configuration for token-kiosk service |
| packages/token-kiosk/helm/Chart.yaml | New Helm chart definition with mc-labels-and-annotations dependency |
| packages/token-kiosk/helm/templates/*.yaml | New Kubernetes templates for deployment, service, and configmap |
| packages/auth-*/helm/values.yaml | Refactored configManager structure for consistency |
| packages/auth-/helm/templates/.yaml | Updated references to use new configManager structure |
| helm/values.yaml | Added token-kiosk service configuration to umbrella chart |
| helm/Chart.yaml | Added token-kiosk as dependency in umbrella chart |
| database: token-kiosk | ||
| port: 5432 | ||
| useExternalSecret: true | ||
| secretName: '' |
There was a problem hiding this comment.
The useExternalSecret is set to true but secretName is empty on line 97. This configuration may cause issues when external secrets are expected but not properly configured.
| secretName: '' | |
| secretName: 'my-secret-name' # Replace 'my-secret-name' with the actual secret name during deployment |
| cloudProvider: | ||
| dockerRegistryUrl: | ||
| imagePullSecretName: '' | ||
| dockerRegistryUrl: my-registry-url.io |
There was a problem hiding this comment.
The dockerRegistryUrl contains a placeholder value 'my-registry-url.io' which should not be committed as a default value in production configuration.
| dockerRegistryUrl: | ||
| imagePullSecretName: '' | ||
| dockerRegistryUrl: my-registry-url.io | ||
| imagePullSecretName: my-registry-secret |
There was a problem hiding this comment.
The imagePullSecretName contains a placeholder value 'my-registry-secret' which should not be committed as a default value in production configuration.
| imagePullSecretName: my-registry-secret | |
| imagePullSecretName: REPLACE_WITH_YOUR_SECRET # Replace this placeholder with the name of your image pull secret in production |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.