Skip to content

feat: 3D set default max-records to 50 and fix filterProductStatus filter (MAPCO-8216)#92

Merged
asafMasa merged 7 commits into
masterfrom
fixMaxRecordsAndSupportGzip
Aug 19, 2025
Merged

feat: 3D set default max-records to 50 and fix filterProductStatus filter (MAPCO-8216)#92
asafMasa merged 7 commits into
masterfrom
fixMaxRecordsAndSupportGzip

Conversation

@asafMasa
Copy link
Copy Markdown

@asafMasa asafMasa commented Aug 11, 2025

Overview

Related Issue / Discussion

Additional Information

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@asafMasa asafMasa changed the title feat: 3D set max-records to 100 and support for gzip feat: 3D set max-records to 50 and support for gzip Aug 11, 2025
alebinson
alebinson previously requested changes Aug 12, 2025
View reviewed changes
Copy link
Copy Markdown

@alebinson alebinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

Comment thread helm/3d/values.yaml
CL-SHLOMIKONCHA
CL-SHLOMIKONCHA requested changes Aug 12, 2025
View reviewed changes
Comment thread helm/3d/values.yaml Outdated
shimoncohen
shimoncohen requested changes Aug 12, 2025
View reviewed changes
Comment thread helm/3d/values.yaml Outdated
Comment thread helm/3d/config/pycsw.cfg Outdated
Comment thread helm/3d/config/pycsw.cfg Outdated
Comment thread helm/3d/values.yaml Outdated
asafMasa and others added 3 commits August 13, 2025 12:22
@asafMasa @shimoncohen
Update helm/3d/values.yaml
5b56f4b 
Co-authored-by: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com>
@asafMasa @shimoncohen
Update helm/3d/config/pycsw.cfg
5773011 
Co-authored-by: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com>
chore: fix cr comments
d67b649
@asafMasa asafMasa changed the title feat: 3D set max-records to 50 and support for gzip feat: 3D set max-records to 50, support for gzip and fix filterProductStatus filter Aug 13, 2025
@asafMasa asafMasa changed the title feat: 3D set max-records to 50, support for gzip and fix filterProductStatus filter feat: 3D set max-records to 50 and fix filterProductStatus filter Aug 18, 2025
@asafMasa asafMasa changed the title feat: 3D set max-records to 50 and fix filterProductStatus filter feat: 3D set default max-records to 50 and fix filterProductStatus filter Aug 18, 2025
@asafMasa asafMasa changed the title feat: 3D set default max-records to 50 and fix filterProductStatus filter feat: 3D set default max-records to 50 and fix filterProductStatus filter (MAPCO-8216) Aug 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 18, 2025 •
edited by atlassian Bot
Loading

🎫 Related Jira Issue: MAPCO-8216

@shimoncohen shimoncohen requested review from alebinson and removed request for alebinson August 19, 2025 14:04
@shimoncohen shimoncohen dismissed alebinson’s stale review August 19, 2025 14:06

Discussed offline.

@asafMasa asafMasa merged commit 6144d68 into master Aug 19, 2025
5 checks passed
@asafMasa asafMasa deleted the fixMaxRecordsAndSupportGzip branch August 19, 2025 14:08
@mapcolonies-devops mapcolonies-devops mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syncush syncush syncush approved these changes

@shimoncohen shimoncohen shimoncohen approved these changes

@CL-SHLOMIKONCHA CL-SHLOMIKONCHA CL-SHLOMIKONCHA approved these changes

@alebinson alebinson Awaiting requested review from alebinson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asafMasa @syncush @alebinson @shimoncohen @CL-SHLOMIKONCHA