Skip to content

fix(update-artifacts-file): artifacts.json will change in the remote helm-charts repo#75

Merged
michalby24 merged 11 commits intomasterfrom
fix-update-artifacs
Jul 3, 2025
Merged

fix(update-artifacts-file): artifacts.json will change in the remote helm-charts repo#75
michalby24 merged 11 commits intomasterfrom
fix-update-artifacs

Conversation

@michalby24
Copy link
Contributor

This update modifies the update-artifacts-file action to support updating artifacts.json in a mapcolonies/helm-charts.
The action now clones the target repo, applies updates using the provided inputs, and pushes the changes back.

@alex131290
Copy link
Contributor

@michalby24 can you please provide a link to a github workflow which has consumed this action where we can see that the execution is working and doing what it's supposed to do?

@michalby24
Copy link
Contributor Author

@michalby24 can you please provide a link to a github workflow which has consumed this action where we can see that the execution is working and doing what it's supposed to do?

https://github.com/MapColonies/actions/actions/runs/16005078010
it was changed in https://github.com/MapColonies/helm-charts/commit/ce2537104e3bd500cb1ce33332c78f77ade61f48

Copy link
Contributor

@netanelC netanelC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acrion supports only helm-charts repo, don't extend it.
What is the use of context? I don't see any usage of it. also, if you will put other value, the workflow will fail

@michalby24
Copy link
Contributor Author

What is the use of context? I don't see any usage of it. also, if you will put other value, the workflow will fail

The context is the scripts execution path, which I have hardcoded since it will not change.

michalby24 and others added 2 commits July 3, 2025 15:56
Co-authored-by: Netanel Cohen <34451523+netanelC@users.noreply.github.com>
@michalby24 michalby24 merged commit f5aa3f0 into master Jul 3, 2025
3 checks passed
@michalby24 michalby24 deleted the fix-update-artifacs branch December 30, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants