fix(tracing): now when debug is enabled the otlp exporter still works#126
Merged
CptSchnitz merged 1 commit intomasterfrom Mar 20, 2025
Merged
fix(tracing): now when debug is enabled the otlp exporter still works#126CptSchnitz merged 1 commit intomasterfrom
CptSchnitz merged 1 commit intomasterfrom
Conversation
|
Hi it is me, your friendly bot helper! 👋 {
"dependencies": {
"@map-colonies/telemetry": "https://ghatmpstorage.blob.core.windows.net/npm-packages/telemetry-0b476a266eee437480f8a58735d1cabecb68b9da.tgz"
}
}The link will expire in a week ⌛ |
syncush
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
Tracingclass in thesrc/tracing/tracing.tsfile to improve the handling of span processors. The most important change is the modification of theprocessorsvariable to be a constant and the addition of a new processor instead of replacing the existing ones when in debug mode.Improvements to span processor handling:
src/tracing/tracing.ts: Changedprocessorsfrom aletto aconstand updated the debug mode logic to push a newSimpleSpanProcessorto the existing array instead of replacing it.