Format Code - prettier #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add replace jshint with format task in default build to include prettier Replace jshint single line hint with hint block to support prettier
prushforth
approved these changes
May 2, 2023
Member
prushforth
left a comment
prushforth
left a comment
There was a problem hiding this comment.
Looks good to me. Once we squash and merge, we can add a .git-blame-ignore-revs file to the root folder, containing the commit hash of the squashed commit. We also have to remember to document that new devs should use the following command to ignore this particular commit, permanently:
git config --global blame.ignoreRevsFile .git-blame-ignore-revs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a new grunt task (to replace the 'test' grunt task) to format code using prettier.
One of the code formats (Conditional ternary operator) performed by prettier seems to cause errors with jshint - maybe jshint is not needed anymore when we use a code formatter.
Seems to format code nicely, though we can finetune it as needed also - https://prettier.io/docs/en/options.html
resolves #773.