Skip to content

allow missing <map-input> el for zoom level when it isn't required #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yhy0217 merged 3 commits into from
Feb 16, 2023
Merged

allow missing <map-input> el for zoom level when it isn't required #754

yhy0217 merged 3 commits into from
Feb 16, 2023

Conversation

@yhy0217
Copy link
Contributor

@yhy0217 yhy0217 commented Feb 15, 2023 •
edited
Loading

Closes #669

  • modify codes, ensure _getZoomForUrl() will not be called and/or the zoom property of template obj will not be read when zoom level is not a variable required by template url (tref)
  • add a test

@yhy0217 yhy0217 marked this pull request as ready for review February 16, 2023 14:10
prushforth
prushforth reviewed Feb 16, 2023
View reviewed changes
@prushforth
Copy link
Member

prushforth commented Feb 16, 2023

LGTM squash and merge when ready

@yhy0217 yhy0217 merged commit 11777d7 into Maps4HTML:main Feb 16, 2023
@yhy0217 yhy0217 deleted the issue669 branch February 24, 2023 16:11
@prushforth prushforth mentioned this pull request Mar 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prushforth prushforth prushforth left review comments

@AliyanH AliyanH Awaiting requested review from AliyanH

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

An <map-input type="zoom" ...> is required for <map-link rel="tile" ...> even though it may not be necessary

2 participants

@yhy0217 @prushforth