Improve error handling #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements all methods present on Rust's `Result` type that can actually be implemented in Java and in a more Java-esque style. There were some methods that are impractical / impossible to implement in Java: - `unchecked_*` for obvious reasons - `unwrap_or_default`: no static polymorphism - more info in the big comment - `into_ok`: No infallible/`!` type in Java, not enough stuff at compile time to work (see comment) - The `impl`s on nested `Result` types, etc. as we can only have 1 class-wide constraint (see comment). Although we could make those `static` methods if we really need them. Possibly, we could also make an `Option<T>` class for more convenience.
This comment was marked as resolved.
This comment was marked as resolved.
This is so that it is different to the plain old constructor.
Seems that it isn't checked on CI, so no reason (other than debugging) to make IntelliJ check for it
(May or may not involve tricking the compiler)
Owner
Author
|
Actually, I'm not sure using |
Checked exceptions are much more ergonomic has they have first-class language support and syntax, unlike my Result type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resulttype (similar to Rust's)Optiontype (could be useful)Result/OptiontypeDecided not to:
Resulttype everywhere in parser codeParsertests to test for error handlingFixes #3