Merge branch '12.1' into 12.2

Author: vuvova

mysql-test/main/delete.result

@@ -779,6 +779,22 @@ id
 Warnings:
 Warning	4207	Index hints are ignored because they are incompatible with RETURNING clause
 drop table t2;
-#
 # End of 11.4 test
 #
+# MDEV-38068 Query doesn't delete all data it should after update to 11.8.4
+#
+create table t1 (id varchar(32), d1 char, key (id), key (d1)) engine=myisam;
+insert into t1 values ('1','A'), ('1','B'), ('1','C'), ('2','D'), ('2','E');
+select count(*) from t1;
+count(*)
+5
+need "range" below
+explain delete from t1 where id = '1';
+id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
+1	SIMPLE	t1	range	id	id	131	NULL	3	Using where
+delete from t1 where id = '1';
+select count(*) from t1;
+count(*)
+2
+drop table t1;
+# End of 11.8 test

mysql-test/main/delete.test

@@ -825,6 +825,18 @@ DELETE FROM t2 ignore index(primary) ORDER BY (id) LIMIT 2 RETURNING id;
 
 drop table t2;
 
---echo #
 --echo # End of 11.4 test
+
 --echo #
+--echo # MDEV-38068 Query doesn't delete all data it should after update to 11.8.4
+--echo #
+create table t1 (id varchar(32), d1 char, key (id), key (d1)) engine=myisam;
+insert into t1 values ('1','A'), ('1','B'), ('1','C'), ('2','D'), ('2','E');
+select count(*) from t1;
+--echo need "range" below
+explain delete from t1 where id = '1';
+delete from t1 where id = '1';
+select count(*) from t1;
+drop table t1;
+
+--echo # End of 11.8 test

mysql-test/main/null_aware_cardinality.result

@@ -1,4 +1,3 @@
-SET @session_start_value = @@new_mode;
 # Small driving table
 CREATE TABLE t1 (a INT, b INT);
 INSERT INTO t1 VALUES (1, 1), (2, 2000),(3,300);
@@ -14,9 +13,6 @@ ANALYZE TABLE t2 PERSISTENT FOR ALL;
 Table	Op	Msg_type	Msg_text
 test.t2	analyze	status	Engine-independent statistics collected
 test.t2	analyze	status	Table is already up to date
-SET @@new_mode = "FIX_INDEX_STATS_FOR_ALL_NULLS";
-Warnings:
-Warning	4200	The setting 'new_mode=FIX_INDEX_STATS_FOR_ALL_NULLS' is ignored. It only exists for compatibility with old installations and will be removed in a future release
 # NULL-rejecting equality t1.b = t2.b will not return any matches
 # because all values of t2.b are NULL. So "rows" = 1 for t2 where 1 is
 # a special value meaning "very few" rows
@@ -82,23 +78,12 @@ id	select_type	table	type	possible_keys	key	key_len	ref	rows	filtered	Extra
 1	SIMPLE	t3	ref	key_ab	key_ab	10	test.t1.a,const	11	100.00	Using where; Using index
 Warnings:
 Note	1003	select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b`,`test`.`t3`.`a` AS `a`,`test`.`t3`.`b` AS `b` from `test`.`t1` join `test`.`t3` where `test`.`t3`.`a` = `test`.`t1`.`a` and `test`.`t3`.`b` is null
-# In the old mode (null-aware estimation is not enabled), "rows" > 1
-SET @@new_mode = "";
-EXPLAIN EXTENDED SELECT * FROM t1 JOIN t2 ON t1.a = t2.a AND t1.b = t2.b;
-id	select_type	table	type	possible_keys	key	key_len	ref	rows	filtered	Extra
-1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	3	100.00	Using where
-1	SIMPLE	t2	ref	key_b	key_b	5	test.t1.b	100	100.00	Using where
-Warnings:
-Note	1003	select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b`,`test`.`t2`.`a` AS `a`,`test`.`t2`.`b` AS `b` from `test`.`t1` join `test`.`t2` where `test`.`t2`.`a` = `test`.`t1`.`a` and `test`.`t2`.`b` = `test`.`t1`.`b`
 # Insert some non-NULL values and re-collect the stats
 INSERT INTO t3 SELECT 1, 1 FROM seq_1_to_100;
 ANALYZE TABLE t3 PERSISTENT FOR COLUMNS (b) INDEXES (key_ab);
 Table	Op	Msg_type	Msg_text
 test.t3	analyze	status	Engine-independent statistics collected
 test.t3	analyze	status	OK
-SET @@new_mode = "FIX_INDEX_STATS_FOR_ALL_NULLS";
-Warnings:
-Warning	4200	The setting 'new_mode=FIX_INDEX_STATS_FOR_ALL_NULLS' is ignored. It only exists for compatibility with old installations and will be removed in a future release
 EXPLAIN EXTENDED SELECT * FROM t1 JOIN t3 ON t1.a = t3.a AND t1.b = t3.b;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	filtered	Extra
 1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	3	100.00	Using where
@@ -158,5 +143,4 @@ EXPLAIN SELECT * FROM t1, t2 WHERE t2.a=t1.a AND t2.b=t1.a;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
 1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	10	Using where
 1	SIMPLE	t2	ref	i1	i1	66	test.t1.a,test.t1.a	1	Using where
-SET @@new_mode = @session_start_value;
 DROP TABLE t1, t2;

mysql-test/main/null_aware_cardinality.test

@@ -1,7 +1,5 @@
 --source include/have_sequence.inc
 
-SET @session_start_value = @@new_mode;
-
 --echo # Small driving table
 CREATE TABLE t1 (a INT, b INT);
 INSERT INTO t1 VALUES (1, 1), (2, 2000),(3,300);
@@ -15,8 +13,6 @@ INSERT INTO t2 SELECT seq/100,  NULL FROM seq_1_to_1000;
 
 ANALYZE TABLE t2 PERSISTENT FOR ALL;
 
-SET @@new_mode = "FIX_INDEX_STATS_FOR_ALL_NULLS";
-
 --echo # NULL-rejecting equality t1.b = t2.b will not return any matches
 --echo # because all values of t2.b are NULL. So "rows" = 1 for t2 where 1 is
 --echo # a special value meaning "very few" rows
@@ -52,16 +48,11 @@ EXPLAIN EXTENDED SELECT * FROM t1 JOIN t3 ON t1.a = t3.a AND t1.b <=> t3.b;
 
 EXPLAIN EXTENDED SELECT * FROM t1 JOIN t3 ON t1.a = t3.a AND t3.b is NULL;
 
---echo # In the old mode (null-aware estimation is not enabled), "rows" > 1
-SET @@new_mode = "";
-EXPLAIN EXTENDED SELECT * FROM t1 JOIN t2 ON t1.a = t2.a AND t1.b = t2.b;
-
 --echo # Insert some non-NULL values and re-collect the stats
 INSERT INTO t3 SELECT 1, 1 FROM seq_1_to_100;
 
 ANALYZE TABLE t3 PERSISTENT FOR COLUMNS (b) INDEXES (key_ab);
 
-SET @@new_mode = "FIX_INDEX_STATS_FOR_ALL_NULLS";
 EXPLAIN EXTENDED SELECT * FROM t1 JOIN t3 ON t1.a = t3.a AND t1.b = t3.b;
 
 --echo # Test composite index for 3 columns. Key prefix is used for access
@@ -99,5 +90,4 @@ ANALYZE TABLE t2 PERSISTENT FOR COLUMNS (b) INDEXES (i1);
 
 EXPLAIN SELECT * FROM t1, t2 WHERE t2.a=t1.a AND t2.b=t1.a;
 
-SET @@new_mode = @session_start_value;
 DROP TABLE t1, t2;

mysql-test/suite/vcol/r/order_by_group_by_subst.result

@@ -222,3 +222,19 @@ a	b
 5	4
 5	5
 drop table t1, t2;
+#
+# MDEV-37422: SIGSEGV failed in base_list_iterator::replace, Assertion `n < m_size'
+#   in Baounds_checked_array, ASAN use-after-poison in JOIN::rollup_make_fields
+#
+CREATE TABLE t1 (
+a INT,
+b INT,
+a1 INT GENERATED ALWAYS AS (a) VIRTUAL,
+INDEX (a1)
+) ENGINE=INNODB;
+SELECT * FROM t1 GROUP BY a WITH ROLLUP;
+a	b	a1
+drop table t1;
+#
+# End of 12.1 tests
+#

mysql-test/suite/vcol/t/order_by_group_by_subst.test

@@ -168,3 +168,22 @@ insert into t1 (a) select seq from seq_1_to_5;
 insert into t2 (b) select seq from seq_1_to_5;
 SELECT a, b FROM t1, t2 GROUP BY a, b HAVING a>2 and b>2;
 drop table t1, t2;
+
+--echo #
+--echo # MDEV-37422: SIGSEGV failed in base_list_iterator::replace, Assertion `n < m_size'
+--echo #   in Baounds_checked_array, ASAN use-after-poison in JOIN::rollup_make_fields
+--echo #
+--source include/have_innodb.inc
+CREATE TABLE t1 (
+  a INT,
+  b INT,
+  a1 INT GENERATED ALWAYS AS (a) VIRTUAL,
+  INDEX (a1)
+) ENGINE=INNODB;
+
+SELECT * FROM t1 GROUP BY a WITH ROLLUP;
+drop table t1;
+
+--echo #
+--echo # End of 12.1 tests
+--echo #

sql/opt_vcol_substitution.cc

@@ -303,7 +303,11 @@ bool substitute_indexed_vcols_for_join(JOIN *join)
   ctx.subst_count= 0;
   if (join->order)
     subst_vcols_in_order(&ctx, join->order, join, false);
-  if (join->group_list)
+  /*
+    Do not do substitution for WITH ROLLUP as that breaks some of its data
+    structures.
+  */
+  if (join->group_list && join->rollup.state == st_rollup::STATE_NONE)
     subst_vcols_in_order(&ctx, join->group_list, join, true);
   if (ctx.subst_count)
   {

sql/sql_class.h

@@ -232,10 +232,6 @@ void old_mode_deprecated_warnings(ulonglong v);
 /* Definitions above that have transitioned from new behaviour to default */
 
 #define NOW_DEFAULT                                             -1
-#define NEW_MODE_TEST_WARNING1                               NOW_DEFAULT
-#define NEW_MODE_TEST_WARNING2                               NOW_DEFAULT
-#define NEW_MODE_FIX_DISK_TMPTABLE_COSTS                     NOW_DEFAULT
-#define NEW_MODE_FIX_INDEX_STATS_FOR_ALL_NULLS               NOW_DEFAULT
 
 #define TEST_NEW_MODE_FLAG(thd, flag) \
   (flag == NOW_DEFAULT ? TRUE : thd->variables.new_behavior & flag)

sql/sql_delete.cc

@@ -312,18 +312,20 @@ template <bool replace>
 int TABLE::delete_row(bool treat_versioned)
 {
   int err= 0;
+  bool remembered_pos= false;
   uchar *del_buf= record[replace ? 1 : 0];
   bool delete_row= !treat_versioned
                    || in_use->lex->vers_conditions.delete_history
                    || versioned(VERS_TRX_ID)
                    || !vers_end_field()->is_max(
                            vers_end_field()->ptr_in_record(del_buf));
 
-  if ((err= file->extra(HA_EXTRA_REMEMBER_POS)))
-    return err;
-
   if (!delete_row)
   {
+    if ((err= file->extra(HA_EXTRA_REMEMBER_POS)))
+      return err;
+    remembered_pos= true;
+
     if (replace)
     {
       store_record(this, record[2]);
@@ -370,7 +372,8 @@ int TABLE::delete_row(bool treat_versioned)
   if (delete_row)
     err= file->ha_delete_row(del_buf);
 
-  (void) file->extra(HA_EXTRA_RESTORE_POS);
+  if (remembered_pos)
+    (void) file->extra(HA_EXTRA_RESTORE_POS);
 
   return err;
 }

sql/sql_statistics.cc

@@ -4164,11 +4164,10 @@ void set_statistics_for_table(THD *thd, TABLE *table)
         (check_eits_preferred(thd) &&
          table->stats_is_read &&
          key_info->read_stats->avg_frequency_is_inited() &&
-         key_info->read_stats->has_stats(thd));
+         key_info->read_stats->has_stats());
 
     // Fill out `all_nulls_key_parts` bitmap
-    if (TEST_NEW_MODE_FLAG(thd, NEW_MODE_FIX_INDEX_STATS_FOR_ALL_NULLS) &&
-        key_info->is_statistics_from_stat_tables)
+    if (key_info->is_statistics_from_stat_tables)
     {
       for (uint part_idx= 0; part_idx < key_info->usable_key_parts; part_idx++)
       {