Skip to content

Commit c24b4b9

Browse files
janlindstromsysprg
authored andcommitted
MDEV-36949 : unstable autoincrement value in galera_toi_ddl_nonconflicting test
Remove show create table because, Test has two concurrent statements: (1) ALTER TABLE t1 ADD COLUMN f3 INTEGER; INSERT INTO t1 VALUES (NULL, 10000, 10000); (2) CREATE UNIQUE INDEX i1 ON t1(f2); If INSERT starts execution and reaches certifying state and execution is switched to CREATE, there will be MDL-conflict. This MDL-conflict is resolved by BF-abort (brute force abort) i.e. INSERT is aborted. But it has already acquired value for auto_increment column from InnoDB. INSERT is then retryed and that will cause new auto_increment value generation. Therefore, later SHOW CREATE TABLE could show unstable values i.e. either value that is generated on schedule where there was no retry and value where there was a retry. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>
1 parent 23b4431 commit c24b4b9

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

mysql-test/suite/galera/r/galera_toi_ddl_nonconflicting.result

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,6 @@ EXPECT_3
3535
SELECT COUNT(*) AS EXPECT_2 FROM INFORMATION_SCHEMA.STATISTICS WHERE TABLE_NAME = 't1';
3636
EXPECT_2
3737
2
38-
SHOW CREATE TABLE t1;
39-
Table Create Table
40-
t1 CREATE TABLE `t1` (
41-
`f1` int(11) NOT NULL AUTO_INCREMENT,
42-
`f2` int(11) DEFAULT NULL,
43-
`f3` int(11) DEFAULT NULL,
44-
PRIMARY KEY (`f1`),
45-
UNIQUE KEY `i1` (`f2`)
46-
) ENGINE=InnoDB AUTO_INCREMENT=2002 DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
4738
SELECT COUNT(*) AS EXPECT_1001 FROM t1;
4839
EXPECT_1001
4940
1001
@@ -54,15 +45,6 @@ EXPECT_3
5445
SELECT COUNT(*) AS EXPECT_2 FROM INFORMATION_SCHEMA.STATISTICS WHERE TABLE_NAME = 't1';
5546
EXPECT_2
5647
2
57-
SHOW CREATE TABLE t1;
58-
Table Create Table
59-
t1 CREATE TABLE `t1` (
60-
`f1` int(11) NOT NULL AUTO_INCREMENT,
61-
`f2` int(11) DEFAULT NULL,
62-
`f3` int(11) DEFAULT NULL,
63-
PRIMARY KEY (`f1`),
64-
UNIQUE KEY `i1` (`f2`)
65-
) ENGINE=InnoDB AUTO_INCREMENT=2047 DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
6648
SELECT COUNT(*) AS EXPECT_1001 FROM t1;
6749
EXPECT_1001
6850
1001

mysql-test/suite/galera/t/galera_toi_ddl_nonconflicting.test

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ SET SESSION wsrep_sync_wait=0;
6666

6767
SELECT COUNT(*) AS EXPECT_3 FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = 't1';
6868
SELECT COUNT(*) AS EXPECT_2 FROM INFORMATION_SCHEMA.STATISTICS WHERE TABLE_NAME = 't1';
69-
SHOW CREATE TABLE t1;
7069
SELECT COUNT(*) AS EXPECT_1001 FROM t1;
7170

7271
--connection node_1
@@ -79,7 +78,6 @@ SELECT COUNT(*) AS EXPECT_1001 FROM t1;
7978

8079
SELECT COUNT(*) AS EXPECT_3 FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = 't1';
8180
SELECT COUNT(*) AS EXPECT_2 FROM INFORMATION_SCHEMA.STATISTICS WHERE TABLE_NAME = 't1';
82-
SHOW CREATE TABLE t1;
8381
SELECT COUNT(*) AS EXPECT_1001 FROM t1;
8482

8583
DROP TABLE t1;

0 commit comments

Comments
 (0)