Feature/test oraclize gas within limit #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clize callback gas cost. Issue: MARKETProtocol#50
…sumed more gas than allowed. Issue: MARKETProtocol#50
The promise will wait up to 30 seconds until Oraclize callback arrives. After the callback arrives it will exit immediately. Issue: MARKETProtocol#50
Contributor
Author
|
And the coverage increased +4% :) |
Contributor
Author
|
If needed, I can squash commits into one and remove the commented out logs. |
Contributor
|
tested this with truffle and ganache and both worked. Will attempt a test net in the future, but that can be pushed down the line a bit. Thanks, this is awesome! |
Contributor
Author
|
@pelsasser great! I tried to 'submit work' on gitcoin but it failed https://etherscan.io/tx/0x83efb8c29abfd6d51e93a56e1d23259b38597eca153b7fa726106c326f7e80a6 unfortunately I cannot re-submit it again. I would be grateful if you could have a look and see if this can be closed. |
Contributor
|
@cryptomental - please should me a message with your ETH address and I can get everything squared out. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #50 .