Wait for alert keyword fails at wait for promise

[IDvoe]

With Browser 12.3.0, when verifying the step wait for ${promsie} fails with this error 'str' object has no attribute 'name'

To Reproduce
Steps to reproduce the behavior:

Test to check alert
    [Arguments]    ${locator}    ${action}    ${text}
    ${promise}    promise to    wait for alert    action=${action}    text=${text}
    click    ${locator}
    wait for    ${promise}    # this is where it fails with  'str' object has no attribute 'name' 

Expected behavior
wait for alert should not fail

Screenshots
Stack trace screenshot

Desktop (please complete the following information):

• OS: iOS (BigSur, intel core)
• Browser: chrome
• Version [e.g. 22]

[aaltat]

@allcontributors please add @IDvoe for bugs.

[allcontributors]

@aaltat

I've put up a pull request to add @IDvoe! 🎉

[aaltat]

This looks pretty bad. As a workaround, could you try:

${promise}    promise to    wait for alert    ${action}    ${text}

[IDvoe]

The workaround doesn't work. I'm using handle future dialogs for time being. Hope you can fix the issue soon.

[luchoagomezt]

The workaround doesn't work. I'm using handle future dialogs for time being. Hope you can fix the issue soon.

Hello IDvoe,
Could you please paste the Robot logs, as in the following example, I would like to see the DEBUG messages:

[IDvoe]

Here are the logs

[luchoagomezt]

@IDvoe, @aaltat
I was able to reproduce the situation. As the value for the name argument action was passed as 'ACCEPT' instead of 'accept', the code passed to the keyword executor the string 'ACCEPT' instead of the object DialogAction.accept resulting in the Future finishing with an AssertionError.

The solution is as simple as passing the argument as 'accept'. Please refer to the example in the documentation for the keyword Wait for Alert:

Should the code also accept the all caps version? that is both 'accept' and 'ACCEPT'

@aaltat ,
The code fix, if both the lower and upper case versions are valid, is to change the following line of code to parts[2].strip().lower():

robotframework-browser/Browser/keywords/promises.py

Line 78 in d1ffa25

if parts[2].strip() in DialogAction.__members__:

[IDvoe]

Thank you, with the browser library 9 the action=ACCEPT worked fine only after updating to 12.3.0, the test started failing. can I use both lower case and upper case for accept when the code fix is released? Thanks once again.

[luchoagomezt]

Thank you, with the browser library 9 the action=ACCEPT worked fine only after updating to 12.3.0, the test started failing. can I use both lower case and upper case for accept when the code fix is released? Thanks once again.

It is a simple fix, as of now only action=accept works, but I will fix the line of code.

[luchoagomezt]

PR at #2009

[aaltat]

Fixed at #2009