Fix name for ntasks in slurm template

[ml-evs]

Hopefully closes #18

[davidwaroquiers]

Thanks, this is indeed a bug.

Maybe @gpetretto can comment on this (I don't fully remember why it is done this way but I remember we discussed about it), but I think the best would probably to modify it in the _convert_qresources method (https://github.com/Matgenix/QToolKit/blob/develop/src/qtoolkit/io/slurm.py#L540) at lines https://github.com/Matgenix/QToolKit/blob/develop/src/qtoolkit/io/slurm.py#L560, setting header_dict["ntasks"] = processes instead of header_dict["number_of_tasks"] = processes.

Note that I think https://github.com/Matgenix/QToolKit/blob/develop/src/qtoolkit/io/slurm.py#L564 should also be changed to header_dict["nodes"] = nodes.

[ml-evs]

I can confirm that making this change allows my slurm job through, can rename however you see fit

[davidwaroquiers]

Now I think I remember. It is done this way so that when a user that knows slurm well want to directly pass a dictionary, he can use the "real" slurm variable.

[gpetretto]

Indeed, the value in the template used to be number_of_tasks, but we decided that the names in the template should preferably match the original names, otherwise one needs to learn one more convention. I probably changed the template after writing the converter for QResources and forgot to change that point. Thanks for fixing this.