This repository was archived by the owner on Mar 21, 2025. It is now read-only.
fix: changed 'utf8' to 'utf-8' for the injected script charset #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix to helpers.js which specified 'utf8' rather than 'utf-8' for the script element charset. As an aside this attribute is deprecated on script tags. It is inherited automatically as utf-8 from the document. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#Deprecated_attributes
3 tasks
Owner
|
thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix to helpers.js which specified 'utf8' rather than 'utf-8' for the script element charset.
As an aside this attribute is deprecated on script tags. It is inherited automatically as utf-8 from the document. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#Deprecated_attributes
What is the current behavior?
Uses invalid/redundant charset value, which causes a warning in most browsers
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Originally dealt with in #195 but wrong commit message.