This repository was archived by the owner on Mar 21, 2025. It is now read-only.
feat: skip tracking dynamically starting from first page #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful to ignore some lazyloaded pages or avoid app-specific duplicate events with pageviewTemplate
abruere
changed the title
MatteoGabriele
approved these changes
May 30, 2019
Owner
MatteoGabriele
left a comment
MatteoGabriele
left a comment
There was a problem hiding this comment.
thanks for the PR and sorry for the late response!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed precise control over tracking and as documented in this PR
shouldRouterUpdateandpageviewOnLoad: falsewere not enough, since the former applies to navigation only, and the latter is global and not dynamic.Having full control of tracking can be useful avoid app-specific duplicate events with pageviewTemplate, due to SSR or any other reason.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
New feature.
What is the current behavior? (You can also link to an open issue here)
An object is required and tracking can’t be prevented.
What is the new behavior (if this is a feature change)?
pageviewTemplatecan return a falsy value to prevent tracking asshouldRouterUpdatealready does.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
Thanks for vue-analytics!