This repository was archived by the owner on Mar 21, 2025. It is now read-only.
Improve typescript declarations #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Improves typings
What is the current behavior? (You can also link to an open issue here)
optionsforinstallmethod are inlined, making them very hard to use in app feat: added typings for vue-analytics #258 (comment)event,exception,time, etc. are missing, so it's impossible to import themWhat is the new behavior (if this is a feature change)?
optiontypings forinstallmethodDoes this PR introduce a breaking change?
It might break compilation for those who already use typescript together with vue-analytics.
Please check if the PR fulfills these requirements
Other information:
Let me know if those typings for
ecommerceare too much.I also added
vuexintodevDependenciesto pullStore<T>type from there and have better declarations foranalyticsMiddleware.