Sprint 11 #3
Open
Sprint 11 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmbabaev
suggested changes
Jan 9, 2023
| case .failure: | ||
| UIBlockingProgressHUD.dismiss() | ||
| print("failure fetchProfile") | ||
| break |
| self.present(alert, animated: true, completion: nil) | ||
|
|
||
| UIBlockingProgressHUD.dismiss() | ||
| break |
| // | ||
|
|
||
| import UIKit | ||
| import ProgressHUD |
There was a problem hiding this comment.
здесь не нужен импорт фреймворка. Частично в этом был смысл выделения отдельного файла-обертки над ProgressHUD
| override func viewDidAppear(_ animated: Bool) { | ||
| super.viewDidAppear(animated) | ||
|
|
||
| if let token = oauth2Service.authToken { |
There was a problem hiding this comment.
token не используется. Обращайте внимание на ворсинки и старайтесь относиться к ним как к ошибкам
| httpMethod: String, | ||
| baseURL: URL = DefaultBaseURL) -> URLRequest { | ||
|
|
||
| var request = URLRequest(url: URL(string: path, relativeTo: baseURL)!) |
There was a problem hiding this comment.
рекомендую избегать использования форс анрапов
| } | ||
|
|
||
| struct UserResult: Codable { | ||
| let profile_image: ImageResult |
There was a problem hiding this comment.
snake_case не используют при именовании полей в Swift. Используйте CodingKeys
Другой вариант - использовать keyDecodingStrategy/keyEncodingStrategy
https://developer.apple.com/documentation/foundation/jsondecoder/keydecodingstrategy/convertfromsnakecase
|
|
||
| static let shared = ProfileImageService() | ||
|
|
||
| static let DidChangeNotification = Notification.Name(rawValue: "ProfileImageProviderDidChange") |
mmbabaev
suggested changes
Jan 9, 2023
| self.switchToTabBarController() | ||
| case .failure: | ||
| UIBlockingProgressHUD.dismiss() | ||
| print("failure fetchProfile") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.