fix(ci): resolve critical race condition in deploy job artifacts

The deploy job was downloading build artifacts to path: ., then running
pnpm install which overwrote the downloaded dist directory. This caused
both smoke-tests and deploy jobs to fail with "Directory does not exist"
errors when trying to access ./dist/apps/web.

Fixed by:
1. Download artifacts to temporary directory (build-artifacts-temp)
2. Install dependencies first
3. Move dist directory from temp to expected location
4. Verify structure and clean up temp directory

This resolves the race condition where pnpm install was overwriting
downloaded build artifacts, preventing successful deployment.

Author: Mearman

.github/workflows/ci.yml

@@ -907,46 +907,47 @@ jobs:
       - name: Setup Pages
         uses: actions/configure-pages@v5
 
-      - name: Install dependencies
-        timeout-minutes: 5
-        run: pnpm install --frozen-lockfile
-
-      - name: Download build artifacts
+      - name: Download build artifacts to temp directory
         uses: actions/download-artifact@v6
         with:
           name: build-artifacts
-          path: .
+          path: build-artifacts-temp
 
-      - name: Install PostHog CLI
-        run: npm install -g @posthog/cli
+      - name: Install dependencies
+        timeout-minutes: 5
+        run: pnpm install --frozen-lockfile
 
-      - name: Verify artifact structure
+      - name: Restore build artifacts
         run: |
-          echo "=== Current directory structure ==="
-          find . -maxdepth 1 -type f -o -type d | head -20
-          echo "=== Checking for dist directory ==="
-          if [ -d "dist" ]; then
-            echo "✅ dist directory found"
-            find dist -maxdepth 2 -type f -o -type d | head -20
-            if [ -d "dist/apps" ]; then
-              echo "✅ dist/apps directory found"
-              find dist/apps -maxdepth 1 -type d
-              if [ -d "dist/apps/web" ]; then
-                echo "✅ dist/apps/web directory found"
-                find dist/apps/web -maxdepth 1 -type f | head -10
-              else
-                echo "❌ dist/apps/web directory NOT found"
-                exit 1
-              fi
-            else
-              echo "❌ dist/apps directory NOT found"
-              exit 1
-            fi
+          echo "=== Restoring build artifacts from temp directory ==="
+          if [ -d "build-artifacts-temp/dist" ]; then
+            echo "✅ Found dist directory in temp artifacts"
+            mv build-artifacts-temp/dist ./dist
+            echo "✅ Moved dist directory to expected location"
           else
-            echo "❌ dist directory NOT found"
+            echo "❌ dist directory not found in temp artifacts"
+            echo "=== Contents of temp directory ==="
+            find build-artifacts-temp -type f -o -type d | head -20
             exit 1
           fi
 
+          # Verify the restored structure
+          if [ -d "dist/apps/web" ]; then
+            echo "✅ dist/apps/web directory restored successfully"
+            find dist/apps/web -maxdepth 1 -type f | head -5
+          else
+            echo "❌ dist/apps/web directory not found after restore"
+            exit 1
+          fi
+
+          # Clean up temp directory
+          rm -rf build-artifacts-temp
+          echo "✅ Temporary artifacts directory cleaned up"
+
+      - name: Install PostHog CLI
+        run: npm install -g @posthog/cli
+
+  
       - name: Inject source map metadata
         run: posthog-cli --host https://eu.posthog.com sourcemap inject --version ${{ github.sha }} --directory ./dist/apps/web
         env: