Added Spanish ToOrdinalWords translations#188
Added Spanish ToOrdinalWords translations#188thunsaker wants to merge 2 commits intoHumanizr:masterfrom
Conversation
|
Is it correct that the form of the ordinal words in Spanish changes depending on number and gender? |
There was a problem hiding this comment.
Now that we've merge ToOrdinalWords into NumberToWordsExtension we should move this into NumberToWordsTests. In fact I missed this on the last PR. Please move the tests to the related NumberToWordsTests classes.
Also we should rename the test methods to match the extension method names; e.g. ToWords and ToOrdinalWords. No need for Spanish as that's
|
@MehdiK Also, I'll add a negative test to make sure numbers higher than 10 aren't being converted. |
|
Thanks. Please move the English ones over too. We should've done it in the last PR; but it slipped under my radar. Please also make sure the open curlies are on a new line. |
There was a problem hiding this comment.
Hi, number 8 should be "octavo" instead of "optimo"
|
As @mexx said before, ordinal words also depends on gender. For example, "The first to arrive", might be "el PRIMERO en llegar" or "la PRIMERA en llegar" depending if it is a man or a woman. In this case I believe the gender may be an argument or something like that. |
|
@fe-rod I'm aware of the issue with gender, I didn't have time to do it in the first pass but wanted to provide a template for others. I was also wondering about possible use cases when someone wants to say the 4th of the month, in Spanish you'd just say "el cuatro" not "el quarto", except the first of the month, "el primer." @MehdiK Do we, or do we need a way to handle humanizing dates with ordinals? ie: Converting April 4, 2014 to April Fourth Two Thousand Fourteen, which can already be done in pieces, but if the Dev tries to apply ordinals to the days of the month, it doesn't work in Spanish. Slightly tangential but just something to think about with the idiosyncrasies of each language. |
There was a problem hiding this comment.
@fe-rod "séptimo" vs "sétimo"? This seems to be a regional difference, is it worth calling out, or just leaving it the "more correct" version "séptimo" until someone complains?
There was a problem hiding this comment.
As far as I know it's "séptimo" (native spanish speaker by the way). What you say is a rule that applies to some words depending on the region. September could be "Setiembre" or "Septiembre", but it is not the case here.
|
Alright...I pulled in @mexx's #147 branch (locally) to get a head start on my ordinal changes with I'd like to hold off on merging this PR until those changes have been finalized and integrated into the master branch. Once that is done the way will be paved for this and future ordinal translations. Thanks for the work you all have been doing! |
|
@thunsaker #147 is in now, and it's quite neat :) You might rebase on upstream and tackle this. Thanks. WRT "ordinal" dates question, we could create an issue and tackle it later. Can you do that please? |
|
BTW @mexx said German and Russian ordinal translation would require both grammatical gender and number. He is going to work on that later. Can you two please coordinate this together so we don't step on each others' toes? |
|
@MehdiK gender and case, number is decided by the number formatted ;) |
|
Sounds good, I'll take a look today after pulling latest to see if it meets my needs for Spanish. |
|
Just give me a few minutes please. I am reviewing and merging #196 which resolves some of the things you were going to tackle here. |
|
@MehdiK no worries, I just woke up. 😴 Probably won't have time to look until this evening. |
|
#196 was just merged. It adds grammatical gender for ToOrdinalWords. |
|
@MehdiK things should be good to go now with the Spanish ordinals! |
|
Merged now. Thanks. |
|
This is now on NuGet as v1.22.1. Thanks for the contribution. |
4 participants
Made possible by #186.