Skip to content

Conversation

@rollandf
Copy link
Member

@rollandf rollandf commented Nov 27, 2024

  • fix some identation for list
  • align style on bash - remove captions

@rollandf rollandf requested review from e0ne and heyvister1 November 27, 2024 10:31
helm show values nvidia/network-operator --version |network-operator-version| > values.yaml
.. code-block:: bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please return this part which had been removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted, and added a description before it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

- remove duplicate install section
- fix some identation for list
- align style on bash - remove captions

Signed-off-by: Fred Rolland <frolland@nvidia.com>
Copy link
Collaborator

@heyvister1 heyvister1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rollandf rollandf merged commit eb3078b into Mellanox:main Nov 27, 2024
1 check passed
@rollandf rollandf deleted the fix-uninstall branch July 16, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants