fix: launch kit doc fixes #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
almaslennikov
force-pushed
the
launch-kit-fixes
branch
from
cf08d27 to
029dfc1
Compare
Documentation previewhttps://mellanox.github.io/network-operator-docs/review/pr-287 |
e0ne
reviewed
Nov 21, 2025
| .. |spectrumxop-repository| replace:: {{ .SpectrumXOperator.Repository }} | ||
| .. |k8s-launch-kit-version| replace:: {{ .NetworkOperator.Version }} | ||
| .. |k8s-launch-kit-component-version| replace:: {{ .NetworkOperator.Version }} | ||
| .. |k8s-launch-kit-component-version| replace:: {{ .NicConfigurationOperator.Version }} # TODO: update to NetworkOperator.ComponentVersion later |
Collaborator
Author
There was a problem hiding this comment.
to keep the config example correct. Launch Kit uses this version to deploy components in the NIC Cluster Policy, and for downstream components we use a different pattern (network-operator-v25.10.0)
Collaborator
There was a problem hiding this comment.
Thanks for the clarification, @almaslennikov. IMO, it's better to hard-code the version here until we introduce K8SLaunchKit.Version but I won't block this PR
rollandf
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.