Skip to content

Redesing cleanup 1 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 17, 2024
Merged

Redesing cleanup 1 #159

merged 15 commits into from
Jan 17, 2024

Conversation

MarcelGeo
Copy link
Collaborator

@MarcelGeo MarcelGeo commented Jan 16, 2024 •
edited
Loading

Details

Scope: Cleanup of unused deps (vuetify, icons ...) and design improvements

🌹 Redesign "shadow"pages and design imrpovements

  • Change password view
    image

  • Not found
    image

  • Email confirmation

    • negative
      image
      -- positive
      image

  • Upload porgress bar (not sure if anyone see this :) )
    image

  • Error for inputs
    image

  • Sidebar title visibility based on scrolling of content
    --Not scrolling (title is hidden)
    image

--Scrolling (title is showing)
image

  • Sidebar width in large screens
  • New favicon

🌐 Global improvements:

  • 💥 vuetify styles and components
  • 💥 unused icons packages from bundle (reduced css size from 1.x MB -> 600KB)
  • 💥 Cleanup of Support for ie and other dead browsers in browserlist file (reduced @mergin/lib CSS to 3KB)
  • 🆕 Added static files for Inter font instead of pinging google servers for font.css and .woff2 font files
  • 🆕 PurgeCSS implementation in @mergin/app - after production build purgecss is calling for cleaning of unused classes from style..css builded by vite. (reduced css size from 600KB -> 78KB)
  • Compress larger (7KB >) SVG files in lib
  • 💥 Disable building umd version of lib

❗ TODO:

  • add help to app header with community , version ... good to start ticket for @harminius

@MarcelGeo
Added:
06dfb12 
- browserlist to 90% browsers (remove ie prefixes)
- tsconfig to es6
- spliting vendor chunks for smaller async loading (we can debug it on prod and decide if sensible for us)
@MarcelGeo
Cleanup:
52a19c8 
- vutify componnents from mergin/app and lib
- action-button, progress-spinner, permission-info
- moved some data view styles to global mm-theme

Added:
- redesign NotFound, VerifyEmail, ChangePassword
- redesign UploadProgress

Updated:
- move upload progress to file browser (no need to add to applications)
@MarcelGeo
Fix show only expire in acces request table
f89dfaf
@MarcelGeo
Merge remote-tracking branch 'origin' into redesing-cleanup-1
2c54e73
@MarcelGeo
Merge remote-tracking branch 'origin/develop-redesign' into redesing-…
814f8ad 
…cleanup-1
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7555540907

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.8%
Totals Coverage Status
Change from base Build 7553122391: 0.0%
Covered Lines: 5477
Relevant Lines: 5839
💛 - Coveralls

@MarcelGeo
Improvement: make Inter font static (no goolge download needed)
5475ec5
@MarcelGeo
Cleanup:
0c810d8 
- vuetify
- unused icons libraries
@MarcelGeo
Added:
76b8016 
- toggleable configurable in app-section-banner (default false)
@MarcelGeo MarcelGeo marked this pull request as draft January 16, 2024 15:31
@MarcelGeo
Compressing svg
89010e2
@MarcelGeo
Install purgecss for remove unused styles (validate in prod build)
5305f2e
@MarcelGeo
Favicon installed
0e654ab
@MarcelGeo
Merge branch 'develop-redesign' into redesing-cleanup-1
b769c89
@MarcelGeo
Update purgecss extractor for primeflex classes
e2066dc
@MarcelGeo
Cleanup:
14f51e6 
- vite unnecessary umd build
- copying non existing files
@MarcelGeo
Changed:
a90199a 
- scrolling of main layout disable
- input error based on figma
- Breadcrumps smaller chevron icon
- narrow sidebar in large screens
- showintg title in sidebar based on scrolling of content element
@MarcelGeo MarcelGeo requested a review from varmar05 January 17, 2024 12:28
@MarcelGeo MarcelGeo marked this pull request as ready for review January 17, 2024 12:28
@MarcelGeo MarcelGeo requested a review from tomasMizera January 17, 2024 12:31
@varmar05 varmar05 merged commit 4696a4e into develop-redesign Jan 17, 2024
@MarcelGeo MarcelGeo deleted the redesing-cleanup-1 branch January 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varmar05 varmar05 varmar05 approved these changes

@tomasMizera tomasMizera Awaiting requested review from tomasMizera

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcelGeo @varmar05