Master dec2018 #46
Merged
Master dec2018 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'selected' function seems to be called on teardown too, when no children are selected (because of the selected-children-changed signal). Fixes quodlibet#2899
Calling main_iteration_do() is cheap so just do it 100 times max each time we need to "wait" some iterations. Also switch to pytest asserts while at it.
Scrolling the mouse wheel seeks waveform seekbar
So we get immediate visual feedback
Closes quodlibet#2928: Add an option to hide time labels
By replacing the combo box with a grid of radio buttons. Fixes quodlibet#2927
Animated display plugin: Add more preset positions
Missing tag plugin
Made the ordering of the album list and cover grid browsers deterministic
quodlibet#2859 Replace scale's label with a SpinButton in pitch plugin's parameters
gdb requires SYS_PTRACE, so add that to the launcher as well
Do all package manager installs in one go and clean up afterwards
It's nice to get some stack traces if things crash
I sometimes get crashes in some dconf code paths. This should avoid it and we should try to not touch the host preferences anyway.
Theme stuff can influence the tests. Use the default theme in all cases.
GNOME is moving away from them and we only mirrored some actions to it for the sake of consistency and not because we need it. So just remove it.
There is currently a hack to not store thumbnails for images in TMPDIR as we use that for embedded images. Skip this during tests.
So we don't have to duplicate the tagging preferences code
Depending on whether QL or Ex Falso is running
Improve tag splitting
* Extract core logic to method * ...and add tests around the export plugin * Notify the library of all changed songs after import * And fix some naming in the tests Fixes quodlibet#3068
This is a backport from upstream pygobject. We currently don't use this API that way so this shouldn't fix anything for QL.
This plugin allows users to vote on the currently playing song using
a thumb-up/thumb-down tally system. This has some benefits over the
vanilla star-rating system by allowing users to make an easier decision
multiple times in order to accurately calculate a final star total.
It will also more accurately measure a users affinity to a song over a
period of time. Unlike the existing auto-rating plugin, this plugin
allows for a neutral state where the rating does not change.
It also doesn't make the assumption that a skipped song is an inferior
song.
You can sort you songs by a score tag ("~#score") in order to sort your
music from least liked to most liked.
So we can build a flatpak for it. This also fixes the appdata IDs which had a .desktop suffix but shouldn't in the new format according to the docs. Also fixes the macOS bundle IDs to match what we use elsewhere.
Added 'Thumb Rating' Plugin
Otherwise an invalid icon has to specified for ToggleButton, which offsets the label.
exfalso: change the app ID from exfalso to io.github.quodlibet.ExFalso
Refactored loop to generator comprehension in LibraryBrowser.save
Also include the docs for both the queue behavior in 4.2 and >=4.3.
Improve ignore & keep songs functionality in queue
We don't need stop logic for persistent mode, since it will always stop at the end anyway. This also fixes a bug where the player would pause at the end if the queue was cleared while a song sourced from the main song list was playing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.