feat(account-api): add group/wallet id parsing support #360
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: David Drazic <david@timechaser.org>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| * | ||
| * @param groupId - The multichain account group ID to validate and parse. | ||
| * @returns The parsed multichain account group ID. | ||
| * @throws When the group ID format is invalid. |
There was a problem hiding this comment.
The reason I suggested having a type of the error in front is because it's proposed by TSDoc and also some editors (like mine) are recognizing it that way. It's not a blocker, but something to think about.
https://tsdoc.org/pages/tags/throws/
They're more specific about their suggestion:
It is suggested, but not required, for the @throws block to start with a line containing only the name of the exception.
For example what I see in editor:
The other way around is like:
So, it's kinda "more semantic" and IDE uses it in some way.
But, anyway this is not hard requirement, just some stuff good to know if you want to consider having in the future.
There was a problem hiding this comment.
I wasn't aware of this TBH. It's good that you share this! I'll definitely start using those then, I thought those were just old type annotation that we were not really using anymore in tsdoc (cause we don't really have rule to enforce this in all the linter/toolings we have in place).
Anyway, I'll make sure to update our docs with this next time! 👍
Adding parsing helpers (similar to the ones we have in `@metamask/utils` for CAIP) for account wallet/group IDs. --------- Co-authored-by: David Drazic <david@timechaser.org>
Adding parsing helpers (similar to the ones we have in
@metamask/utilsfor CAIP) for account wallet/group IDs.