Exract OpenSea assets API #1008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nController and moved into a separate module.
|
Sorry for letting this get stale @VSaric ! I see there are now some conflicts; we can prioritize this review once they have been resolved |
|
@VSaric This PR has been open for a while. Is this a change that we're still interested in making? If so, do you want a review? If not, should we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Description
The OpenSea API interactions have been extracted from the NftDetectionController and moved into a separate module. The API interactions have been extracted to simplify the controller, and make it easier to thoroughly test the API interactions and the controller logic.