Add (more) logging to NetworkController #1374
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetworkController features asynchronous behavior that can be quite tricky to debug. Specifically, for a brief moment in time, more than one network may be "active" simultaneously. This can happen if the network is switched before the code responsible for establishing a preconfigured network (triggered via `initializeProvider` or one of the several ways to switch the network) has yet to complete. This logging should aid us in writing and debugging this behavior.
|
After discussion, we determined that this was a lower priority PR to merge. |
|
I'll keep working on this to add the logger to the network client instead of the provider, but this isn't high priority — we can always add this after the merge. |
desi
added
the
team-wallet-framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NetworkController features asynchronous behavior that can be quite tricky to debug. Specifically, for a brief moment in time, more than one network may be "active" simultaneously. This can happen if the network is switched before the code responsible for establishing a preconfigured network (triggered via
initializeProvideror one of the several ways to switch the network) has yet to complete. This logging should aid us in writing and debugging this behavior.Changes
There should be no functional changes.
References
Relates to #1375.
Checklist