Skip to content

chore: remove multichain deprecated package #5960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 12, 2025
Merged

chore: remove multichain deprecated package #5960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cc5f942
chore: remove multichain deprecated package
ffmcgee725 Jun 11, 2025
07e68d3
chore: update README.md
ffmcgee725 Jun 11, 2025
867a3df
chore: update CODEOWNERS
ffmcgee725 Jun 11, 2025
3764b8e
build: update yarn.lock
ffmcgee725 Jun 11, 2025
4edc7fd
lint
ffmcgee725 Jun 11, 2025
30bc310
chore: remove remaining refs to multichain deprecated package
ffmcgee725 Jun 12, 2025
198592f
chore: remove package from CODEOWNERS
ffmcgee725 Jun 12, 2025
cc512c7
chore: update-readme-content
ffmcgee725 Jun 12, 2025
d06c694
Merge branch 'main' into chore/deprecate-multichain-package
ffmcgee725 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
## Wallet API Platform Team
/packages/chain-agnostic-permission @MetaMask/wallet-api-platform-engineers
/packages/eip1193-permission-middleware @MetaMask/wallet-api-platform-engineers
/packages/multichain @MetaMask/wallet-api-platform-engineers
/packages/multichain-api-middleware @MetaMask/wallet-api-platform-engineers
/packages/queued-request-controller @MetaMask/wallet-api-platform-engineers
/packages/selected-network-controller @MetaMask/wallet-api-platform-engineers
Expand Down Expand Up @@ -129,8 +128,6 @@
/packages/phishing-controller/CHANGELOG.md @MetaMask/product-safety @MetaMask/wallet-framework-engineers
/packages/profile-sync-controller/package.json @MetaMask/identity @MetaMask/wallet-framework-engineers
/packages/profile-sync-controller/CHANGELOG.md @MetaMask/identity @MetaMask/wallet-framework-engineers
/packages/multichain/package.json @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/multichain/CHANGELOG.md @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/queued-request-controller/package.json @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/queued-request-controller/CHANGELOG.md @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/selected-network-controller/package.json @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
Expand Down
19 changes: 9 additions & 10 deletions README.md
View file
Open in desktop
Copy link
Contributor

@mcmire mcmire Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are more things to remove here, can you run yarn update-readme-content? I see four lines to remove when I do that:

 multichain --> controller_utils;
 multichain --> json_rpc_engine;
 multichain --> network_controller;
 multichain --> permission_controller;

Copy link
Member Author

@ffmcgee725 ffmcgee725 Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc512c7

Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ Each package in this repository has its own README where you can find installati
- [`@metamask/keyring-controller`](packages/keyring-controller)
- [`@metamask/logging-controller`](packages/logging-controller)
- [`@metamask/message-manager`](packages/message-manager)
- [`@metamask/multichain`](packages/multichain)
- [`@metamask/multichain-api-middleware`](packages/multichain-api-middleware)
- [`@metamask/multichain-network-controller`](packages/multichain-network-controller)
- [`@metamask/multichain-transactions-controller`](packages/multichain-transactions-controller)
Expand Down Expand Up @@ -79,7 +78,7 @@ Each package in this repository has its own README where you can find installati
%%{ init: { 'flowchart': { 'curve': 'bumpX' } } }%%
graph LR;
linkStyle default opacity:0.5
account_wallet_controller(["@metamask/account-tree-controller"]);
account_tree_controller(["@metamask/account-tree-controller"]);
accounts_controller(["@metamask/accounts-controller"]);
address_book_controller(["@metamask/address-book-controller"]);
announcement_controller(["@metamask/announcement-controller"]);
Expand All @@ -106,7 +105,6 @@ linkStyle default opacity:0.5
keyring_controller(["@metamask/keyring-controller"]);
logging_controller(["@metamask/logging-controller"]);
message_manager(["@metamask/message-manager"]);
multichain(["@metamask/multichain"]);
multichain_api_middleware(["@metamask/multichain-api-middleware"]);
multichain_network_controller(["@metamask/multichain-network-controller"]);
multichain_transactions_controller(["@metamask/multichain-transactions-controller"]);
Expand All @@ -129,9 +127,9 @@ linkStyle default opacity:0.5
token_search_discovery_controller(["@metamask/token-search-discovery-controller"]);
transaction_controller(["@metamask/transaction-controller"]);
user_operation_controller(["@metamask/user-operation-controller"]);
account_wallet_controller --> base_controller;
account_wallet_controller --> accounts_controller;
account_wallet_controller --> keyring_controller;
account_tree_controller --> base_controller;
account_tree_controller --> accounts_controller;
account_tree_controller --> keyring_controller;
accounts_controller --> base_controller;
accounts_controller --> keyring_controller;
accounts_controller --> network_controller;
Expand All @@ -148,6 +146,7 @@ linkStyle default opacity:0.5
assets_controllers --> keyring_controller;
assets_controllers --> network_controller;
assets_controllers --> permission_controller;
assets_controllers --> phishing_controller;
assets_controllers --> preferences_controller;
assets_controllers --> transaction_controller;
base_controller --> json_rpc_engine;
Expand Down Expand Up @@ -192,6 +191,7 @@ linkStyle default opacity:0.5
ens_controller --> base_controller;
ens_controller --> controller_utils;
ens_controller --> network_controller;
error_reporting_service --> base_controller;
eth_json_rpc_provider --> json_rpc_engine;
gas_fee_controller --> base_controller;
gas_fee_controller --> controller_utils;
Expand All @@ -203,10 +203,6 @@ linkStyle default opacity:0.5
logging_controller --> controller_utils;
message_manager --> base_controller;
message_manager --> controller_utils;
multichain --> controller_utils;
multichain --> json_rpc_engine;
multichain --> network_controller;
multichain --> permission_controller;
multichain_api_middleware --> chain_agnostic_permission;
multichain_api_middleware --> controller_utils;
multichain_api_middleware --> json_rpc_engine;
Expand All @@ -226,6 +222,7 @@ linkStyle default opacity:0.5
name_controller --> controller_utils;
network_controller --> base_controller;
network_controller --> controller_utils;
network_controller --> error_reporting_service;
network_controller --> eth_json_rpc_provider;
network_controller --> json_rpc_engine;
notification_services_controller --> base_controller;
Expand Down Expand Up @@ -261,6 +258,8 @@ linkStyle default opacity:0.5
sample_controllers --> base_controller;
sample_controllers --> controller_utils;
sample_controllers --> network_controller;
seedless_onboarding_controller --> base_controller;
seedless_onboarding_controller --> keyring_controller;
selected_network_controller --> base_controller;
selected_network_controller --> json_rpc_engine;
selected_network_controller --> network_controller;
Expand Down
74 changes: 0 additions & 74 deletions eslint-warning-thresholds.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,80 +256,6 @@
"packages/message-manager/src/utils.ts": {
"@typescript-eslint/no-unused-vars": 1
},
"packages/multichain/src/adapters/caip-permission-adapter-eth-accounts.test.ts": {
"import-x/order": 1
},
"packages/multichain/src/adapters/caip-permission-adapter-eth-accounts.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1,
"jsdoc/tag-lines": 5
},
"packages/multichain/src/adapters/caip-permission-adapter-permittedChains.test.ts": {
"import-x/order": 1
},
"packages/multichain/src/adapters/caip-permission-adapter-permittedChains.ts": {
"jsdoc/tag-lines": 5
},
"packages/multichain/src/adapters/caip-permission-adapter-session-scopes.test.ts": {
"@typescript-eslint/no-unused-vars": 2
},
"packages/multichain/src/caip25Permission.test.ts": {
"@typescript-eslint/no-unused-vars": 5
},
"packages/multichain/src/caip25Permission.ts": {
"@typescript-eslint/no-unused-vars": 1
},
"packages/multichain/src/handlers/wallet-getSession.ts": {
"@typescript-eslint/no-unused-vars": 1,
"jsdoc/require-returns": 1
},
"packages/multichain/src/handlers/wallet-invokeMethod.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1,
"@typescript-eslint/no-unused-vars": 1,
"jsdoc/require-returns": 1
},
"packages/multichain/src/handlers/wallet-revokeSession.test.ts": {
"import-x/order": 1,
"prettier/prettier": 2
},
"packages/multichain/src/handlers/wallet-revokeSession.ts": {
"@typescript-eslint/no-unused-vars": 1,
"jsdoc/require-returns": 1
},
"packages/multichain/src/middlewares/MultichainMiddlewareManager.test.ts": {
"prettier/prettier": 1
},
"packages/multichain/src/middlewares/MultichainSubscriptionManager.ts": {
"@typescript-eslint/prefer-readonly": 2,
"import-x/order": 1
},
"packages/multichain/src/middlewares/multichainMethodCallValidator.test.ts": {
"@typescript-eslint/prefer-promise-reject-errors": 20
},
"packages/multichain/src/scope/assert.test.ts": {
"@typescript-eslint/no-unused-vars": 3
},
"packages/multichain/src/scope/assert.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1
},
"packages/multichain/src/scope/authorization.test.ts": {
"@typescript-eslint/no-unused-vars": 2
},
"packages/multichain/src/scope/errors.ts": {
"jsdoc/tag-lines": 5
},
"packages/multichain/src/scope/filter.test.ts": {
"jest/no-conditional-in-test": 9
},
"packages/multichain/src/scope/filter.ts": {
"@typescript-eslint/no-unused-vars": 1,
"jsdoc/require-returns": 1
},
"packages/multichain/src/scope/supported.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 6
},
"packages/multichain/src/scope/validation.ts": {
"jsdoc/tag-lines": 2
},
"packages/name-controller/src/NameController.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1,
"@typescript-eslint/prefer-readonly": 2
Expand Down
206 changes: 0 additions & 206 deletions packages/multichain/CHANGELOG.md
View file
Open in desktop

This file was deleted.

Loading
Loading