chore: call revoke token in background #6184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshuchawla009
changed the title
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Comment on lines
+657
to
+662
| await this.#createNewVaultWithAuthData({ | ||
| password, | ||
| rawToprfEncryptionKey: toprfEncryptionKey, | ||
| rawToprfPwEncryptionKey: toprfPwEncryptionKey, | ||
| rawToprfAuthKeyPair: toprfAuthKeyPair, | ||
| }); |
Contributor
There was a problem hiding this comment.
note that #createNewVaultWithAuthData is potentially an expensive operation.
it runs encryptWithDetail(pw, vaultData), which involves the intentionally slow pbkdf2 key derivation step.
as you are increasing the usage of vault encryption, you are driving up cpu usage.
Comment on lines
+665
to
+677
| this.#revokeRefreshTokenAndUpdateState(revokeToken) | ||
| .then(() => { | ||
| // re-creating vault to persist the new revoke token | ||
| return this.#createNewVaultWithAuthData({ | ||
| password, | ||
| rawToprfEncryptionKey: toprfEncryptionKey, | ||
| rawToprfPwEncryptionKey: toprfPwEncryptionKey, | ||
| rawToprfAuthKeyPair: toprfAuthKeyPair, | ||
| }); | ||
| }) | ||
| .catch((error) => { | ||
| log('Error revoking refresh token', error); | ||
| }); |
Contributor
There was a problem hiding this comment.
writing the vault asynchronously like this is dangerous as it can lead to vault corruption.
imagine another piece of code updates the vault in the meantime. when this code here is executed after that, the vault will be overwritten with some old data.
Comment on lines
+782
to
+795
| this.#revokeRefreshTokenAndUpdateState(revokeToken) | ||
| .then(() => { | ||
| // re-creating vault to persist the new revoke token. | ||
| // TODO: Optimize this function such that updates to vault wont require re-creating the vault. | ||
| return this.#createNewVaultWithAuthData({ | ||
| password: globalPassword, | ||
| rawToprfEncryptionKey: latestEncKey, | ||
| rawToprfPwEncryptionKey: latestPwEncKey, | ||
| rawToprfAuthKeyPair: latestAuthKeyPair, | ||
| }); | ||
| }) | ||
| .catch((error) => { | ||
| log('Error revoking refresh token', error); | ||
| }); |
Contributor
There was a problem hiding this comment.
see comment above, we can't do this
matthewwalsh0
added a commit
that referenced
this pull request
Nov 10, 2025
## Explanation Support Relay quotes requiring multiple transactions, such as a token approval and deposit. Use fallback gas limit if missing in transaction data. ## References Related to [#6184](MetaMask/MetaMask-planning#6184) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds multi-transaction support for Relay quotes with batch submission, fallback gas handling, and shared transaction ID collection utility. > > - **Relay strategy**: > - Support multiple transactions per quote: submit via `TransactionController:addTransactionBatch`, collect required IDs with `collectTransactionIds`, wait for all confirmations, and return last tx `hash`. > - Poll Relay status from the last step; set `isIntentComplete` when `skipTransaction`. > - Normalize params with fallback `gas` using `RELAY_FALLBACK_GAS_LIMIT`. > - Quote fees: compute source network fee using total gas across items or fallback when missing. > - **Utils**: > - Add `utils/transaction#collectTransactionIds` and use it in Bridge/Relay; remove in-file implementation from Bridge. > - **Types/Mocks**: > - Make `RelayQuote.steps[].items[].data.gas` optional; extend messenger to handle `TransactionController:addTransactionBatch`. > - **Changelog**: > - Note support for Relay quotes with multiple transactions. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7c30789. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
Checklist