feat: Rename messagingSystem to messenger
#6337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
rename-messaging-system-protected-instance-variable
branch
from
e49ce28 to
3554bc5
Compare
Gudahtt
force-pushed
the
messenger-migrate-base-controller
branch
2 times, most recently
from
ae71891 to
67c7853
Compare
Gudahtt
force-pushed
the
rename-messaging-system-protected-instance-variable
branch
from
3554bc5 to
cbff2e3
Compare
On the `next` version of the `BaseController`, the protected instance variable `messagingSystem` has been renamed to `messenger`. Fixes #6336
Gudahtt
force-pushed
the
rename-messaging-system-protected-instance-variable
branch
from
cbff2e3 to
b79f543
Compare
|
Rebased to resolve a conflict in the changelog |
Gudahtt
deleted the
rename-messaging-system-protected-instance-variable
branch
Gudahtt
added a commit
that referenced
this pull request
Oct 27, 2025
This comment has had this mistake since #6337
4 tasks
Gudahtt
added a commit
that referenced
this pull request
Oct 27, 2025
Various variables have been renamed from `messagingSystem` to `messenger` for consistency. These packages have all updated to the next version of the `BaseController`, which dropped the term `messagingSystem` in #6337.
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Explanation This comment has had this mistake since #6337 ## References Fixes mistake in comment introduced in #6337 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Fixes a comment in `BaseController.ts` to reference `messenger` instead of `messagingSystem`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ca4c894. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Explanation Various variables have been renamed from `messagingSystem` to `messenger` for consistency. These packages have all updated to the next version of the `BaseController`, which dropped the term `messagingSystem` in #6337. ## References N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > <sup>[Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) is generating a summary for commit f56bc49. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
On the
nextversion of theBaseController, the protected instance variablemessagingSystemhas been renamed tomessenger.References
Fixes #6336
Checklist