chore: Remove is base controller #6341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
remove-is-base-controller
branch
from
d1af3c4 to
7c0ecbf
Compare
Gudahtt
force-pushed
the
messenger-migrate-base-controller
branch
2 times, most recently
from
ae71891 to
67c7853
Compare
Gudahtt
force-pushed
the
remove-is-base-controller
branch
from
7c0ecbf to
8163913
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Remove the `isBaseController` utility function. Fixes #6340
Gudahtt
force-pushed
the
remove-is-base-controller
branch
from
8163913 to
5fddbe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Remove the
isBaseControllerutility function.References
Fixes #6340
Checklist