Skip to content

fix: Add return type annotation to getCaip25PermissionFromLegacyPermissions #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

fix: Add return type annotation to getCaip25PermissionFromLegacyPermissions #6382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5520f1
Add return type annotation to `getCaip25PermissionFromLegacyPermissions`
MajorLift Aug 26, 2025
baf7c0e
Add changelog entry
MajorLift Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/chain-agnostic-permission/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Add return type annotation to `getCaip25PermissionFromLegacyPermissions` to make its return output assignable to `RequestedPermissions` ([#6382](https://github.com/MetaMask/core/pull/6382))

## [1.1.1]

### Changed
Expand Down
9 changes: 8 additions & 1 deletion packages/chain-agnostic-permission/src/caip25Permission.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,14 @@ export const getCaip25PermissionFromLegacyPermissions =
value: Hex[];
}[];
};
}) => {
}): {
[Caip25EndowmentPermissionName]: {
caveats: NonEmptyArray<{
type: typeof Caip25CaveatType;
value: typeof caveatValueWithAccountsAndChains;
}>;
};
} => {
const permissions = pick(requestedPermissions, [
PermissionKeys.eth_accounts,
PermissionKeys.permittedChains,
Expand Down
Loading