-
-
Notifications
You must be signed in to change notification settings - Fork 252
refactor: migrate ErrorReportingService
to @metamask/messenger
#6462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikesposito
wants to merge
6
commits into
main
Choose a base branch
from
mikesposito/messenger/error-reporting-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc65bbf
to
74e5fca
Compare
43 tasks
mcmire
reviewed
Sep 10, 2025
Comment on lines
+98
to
105
* type AllActions = MessengerActions<ErrorReportingServiceMessenger>; | ||
* | ||
* type AllEvents = MessengerEvents<ErrorReportingServiceMessenger>; | ||
* | ||
* type RootMessenger = Messenger<'Root', AllActions, AllEvents>; | ||
* | ||
* // Create a global messenger. | ||
* const globalMessenger = new Messenger(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can simplify this a bit? Also in this example should we go with global messenger instead of root messenger to match the variable name below this?
Suggested change
* type AllActions = MessengerActions<ErrorReportingServiceMessenger>; | |
* | |
* type AllEvents = MessengerEvents<ErrorReportingServiceMessenger>; | |
* | |
* type RootMessenger = Messenger<'Root', AllActions, AllEvents>; | |
* | |
* // Create a global messenger. | |
* const globalMessenger = new Messenger(); | |
* type GlobalMessenger = Messenger< | |
* 'Global', | |
* MessengerActions<ErrorReportingServiceMessenger>, | |
* MessengerEvents<ErrorReportingServiceMessenger> | |
* >; | |
* | |
* // Create a global messenger. | |
* const globalMessenger: GlobalMessenger = new Messenger(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
ErrorReportingService
to the new@metamask/messenger
message bus, as opposed to the one exported from@metamask/base-controller
.References
Checklist
Note
Migrate
ErrorReportingService
and tests to@metamask/messenger
, add the dependency, and document the breaking change.@metamask/base-controller
RestrictedMessenger
to@metamask/messenger
Messenger
acrosssrc/error-reporting-service.ts
.Messenger
API (namespaces, generics, delegation, andmessenger.call
).packages/error-reporting-service/src/error-reporting-service.test.ts
to use@metamask/messenger
types and construction.@metamask/messenger
inpackage.json
.Messenger
API.Written by Cursor Bugbot for commit 393e935. This will update automatically on new commits. Configure here.