Skip to content

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Sep 9, 2025

Explanation

This PR migrates RemoteFeatureFlagController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates RemoteFeatureFlagController to @metamask/messenger, updates metadata and tests, adjusts exports/types, and adds the new dependency.

  • RemoteFeatureFlagController (BREAKING):
    • Switches messenger from RestrictedMessenger in @metamask/base-controller to Messenger from @metamask/messenger.
    • Updates BaseController imports to @metamask/base-controller/next and metadata keys (anonymous -> includeInDebugSnapshot).
    • Makes controllerName internal; updates tests to define and use namespaced messenger instances.
  • Exports/Types:
    • Move RemoteFeatureFlagControllerState type to remote-feature-flag-controller and export it from there; remove it from remote-feature-flag-controller-types.
    • Adjust index.ts exports accordingly.
  • Tests:
    • Update to new messenger API/types; fix deriveStateFromMetadata usage and snapshots.
  • Build/Config:
    • Add @metamask/messenger dependency and TS project references.
  • Changelog:
    • Note breaking change to use new Messenger.

Written by Cursor Bugbot for commit a0fdd49. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s requested review from a team as code owners September 9, 2025 10:01
@cryptodev-2s cryptodev-2s self-assigned this Sep 9, 2025
@cryptodev-2s cryptodev-2s changed the title refactor: migrate RemoteFeatureFlagController to @metamask/messenger refactor: migrate RemoteFeatureFlagController to @metamask/messenger Sep 9, 2025
@cryptodev-2s cryptodev-2s mentioned this pull request Sep 9, 2025
43 tasks
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/remote-feature-flag-controller branch 2 times, most recently from 40ee512 to dd1859e Compare September 9, 2025 10:25
mcmire
mcmire previously approved these changes Sep 10, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/remote-feature-flag-controller branch from dd1859e to eb1e428 Compare September 24, 2025 14:20
@cryptodev-2s cryptodev-2s requested a review from a team September 24, 2025 14:21
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/remote-feature-flag-controller branch from eb1e428 to 779543d Compare October 7, 2025 09:05
mcmire
mcmire previously approved these changes Oct 7, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants