-
-
Notifications
You must be signed in to change notification settings - Fork 252
refactor: migrate RateLimitController
to @metamask/messenger
#6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
faa66e5
to
5ba04c4
Compare
5ba04c4
to
b4e2db0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, noticed one thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…r/rate-limit-controller
Explanation
This PR migrates
RateLimitController
to the new@metamask/messenger
message bus, as opposed to the one exported from@metamask/base-controller
.References
Checklist
Note
Migrates
RateLimitController
to the new@metamask/messenger
API (from@metamask/base-controller
), updating types/tests, metadata, and package/config files.@metamask/base-controller/next
and@metamask/messenger
(replaceRestrictedMessenger
, adjust action/event types, usemessenger.registerActionHandler
).name
tocontrollerName
; update metadata flag toincludeInDebugSnapshot
.Messenger
with namespaces; update types and calls.@metamask/messenger
; add TS project references tomessenger
.RateLimitController
file.Messenger
from@metamask/messenger
.Written by Cursor Bugbot for commit f30eacf. This will update automatically on new commits. Configure here.