-
-
Notifications
You must be signed in to change notification settings - Fork 252
refactor: migrate MultichainAccountService
to @metamask/messenger
#6544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cryptodev-2s
wants to merge
13
commits into
main
Choose a base branch
from
cryptodev-2s/messenger/multichain-account-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: migrate MultichainAccountService
to @metamask/messenger
#6544
cryptodev-2s
wants to merge
13
commits into
main
from
cryptodev-2s/messenger/multichain-account-service
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
18f8701
to
2ea0719
Compare
2ea0719
to
f22848c
Compare
mcmire
previously approved these changes
Sep 10, 2025
…r/multichain-account-service
…r/multichain-account-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
MultichainAccountService
to the new@metamask/messenger
message bus, as opposed to the one exported from@metamask/base-controller
.References
Checklist
Note
Replaces base-controller RestrictedMessenger with the new @metamask/messenger across service, tests, and types, adding delegation-based messaging and updating configs.
@metamask/base-controller
Messenger/RestrictedMessenger
with@metamask/messenger
.getRootMessenger()
and delegatedgetMultichainAccountServiceMessenger()
with explicit allowedactions/events
.type RootMessenger
and updateMultichainAccountServiceMessenger
to use the newMessenger
types.rootMessenger.publish/registerActionHandler
, new types) and adjust constructor wiring.src/types.ts
to use@metamask/messenger
types; narrowAllowedActions/AllowedEvents
to internal types and update messenger signature.@metamask/messenger
and reference it intsconfig
project references.@metamask/messenger
.Written by Cursor Bugbot for commit 52df0d8. This will update automatically on new commits. Configure here.