chore: Update eth-json-rpc-middleware
#6714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
update-eth-json-rpc-middleware
branch
from
59e276c to
ba0480e
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Gudahtt
force-pushed
the
update-eth-json-rpc-middleware
branch
from
ba0480e to
28114e5
Compare
Gudahtt
commented
Sep 24, 2025
| "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch" | ||
| }, | ||
| "dependencies": { | ||
| "@metamask/eth-json-rpc-middleware": "^17.0.1", |
There was a problem hiding this comment.
This was unused since #6477
jiexi
previously approved these changes
Sep 24, 2025
ffmcgee725
previously approved these changes
Sep 25, 2025
Gudahtt
force-pushed
the
update-eth-json-rpc-middleware
branch
from
3fe373b to
76f7da8
Compare
|
Rebased to resolve conflicts in changelog |
jiexi
approved these changes
Oct 3, 2025
Gudahtt
force-pushed
the
update-eth-json-rpc-middleware
branch
from
76f7da8 to
a235340
Compare
Update `@metamask/eth-json-rpc-middleware` from v17 to v18. The breaking changes relate to dropping support for the legacy middleware function that pre-dates the creation of the RPC service, and some minor type changes regarding that RPC service parameter. Changelog: https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/CHANGELOG.md#1800 Additionally, this dependency was removed completely from `@metamask/eip-5792-middleware` because it was unused.
Gudahtt
force-pushed
the
update-eth-json-rpc-middleware
branch
from
a235340 to
6055771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Update
@metamask/eth-json-rpc-middlewarefrom v17 to v18. The breaking changes relate to dropping support for the legacy middleware function that pre-dates the creation of the RPC service, and some minor type changes regarding that RPC service parameter.Changelog: https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/CHANGELOG.md#1800
References
N/A
Checklist
Note
Upgrade
@metamask/eth-json-rpc-middlewareto v18 innetwork-controllerand remove it fromeip-5792-middleware.packages/network-controller: Bump@metamask/eth-json-rpc-middlewarefrom^17.0.1to^18.0.0; update changelog accordingly.packages/eip-5792-middleware: Remove dependency on@metamask/eth-json-rpc-middleware; update changelog accordingly.Written by Cursor Bugbot for commit 6055771. This will update automatically on new commits. Configure here.