fix: fix api fetcher balances #6812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
previously approved these changes
Oct 10, 2025
bergarces
force-pushed
the
fix/fix-api-fetcher-balances
branch
from
01f9177 to
d397002
Compare
juanmigdr
previously approved these changes
Oct 10, 2025
Prithpal-Sooriya
approved these changes
Oct 10, 2025
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used ## **Related issues** Fixes: #21030 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used ## **Related issues** Fixes: #21030 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
salimtb
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used Fixes: #21030 ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used ## **Related issues** Fixes: #21030 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
runway-github bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used ## **Related issues** Fixes: #21030 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
7 tasks
weitingsun
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used Fixes: #21030 ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
weitingsun
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used Fixes: #21030 ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Cal-L
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 14, 2025
- fix: cp-7.57.0 fix api fetcher balances (#21014) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used ## **Related issues** Fixes: #21030 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use checksum addresses for native tokens and original casing for ERC-20, and adds a Yarn patch for `@metamask/assets-controllers`. > > - **Assets Controllers (API balance fetcher)**: > - In `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`, emit `account` and track `nativeBalancesFromAPI` using `finalAccount`: > - Use checksum address for native (`token === ZERO_ADDRESS`). > - Use original `addressPart` for ERC-20. > - **Dependencies**: > - Adds Yarn patch for `@metamask/assets-controllers@78.0.1` in `package.json` and updates `yarn.lock` to the patched resolution. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 066a3d4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [368c6ec](368c6ec) Co-authored-by: Salim TOUBAL <salim.toubal@outlook.com> Co-authored-by: Cal Leung <cal.leung@consensys.net>
7 tasks
weitingsun
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 15, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The `AccountsApiBalanceFetcher` had a bug caused by address format incompatibility between controllers: - `TokenBalancesController` uses lowercase addresses for ERC20 tokens - `AccountTrackerController` uses checksum addresses for native tokens The original code always checksummed all addresses, causing a wrong token balances state core PR: MetaMask/core#6812 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: fix balances issue update when api fetcher is used ## **Related issues** Fixes: #21030 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `AccountsApiBalanceFetcher` to use the correct account address format per token type and applies Yarn patches for `@metamask/assets-controllers` v78/v79. > > - **Services**: > - `dist/multi-chain-accounts-service/api-balance-fetcher.cjs`: > - Introduces `finalAccount` based on token type (zero address vs. others). > - Uses `finalAccount` for `nativeBalancesFromAPI` keys and returned `account` field. > - **Build/Tooling**: > - Adds Yarn patches for `@metamask/assets-controllers` `^78.0.1` and `^79.0.0` in `package.json` and `.yarn/patches/`. > - Updates `yarn.lock` to reference patched `@metamask/assets-controllers` 79.0.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3968057. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Current Issue:
The
AccountsApiBalanceFetcherhad a bug caused by address format incompatibility between controllers:TokenBalancesControlleruses lowercase addresses for ERC20 tokensAccountTrackerControlleruses checksum addresses for native tokensThe original code always checksummed all addresses, causing a wrong token balances state
Solution:
Fixed by implementing conditional address formatting:
AccountTrackerController)TokenBalancesController)Also fixed the
|| ''fallback bug that could pass empty strings to thechecksum()function.References
AccountsApiBalanceFetcherby ensuring controller-compatible address formattingChecklist
Note
Aligns address casing between controllers by conditionally formatting account addresses in
AccountsApiBalanceFetcherand updatingTokenBalancesControllerstate access; updates changelog.multi-chain-accounts-service/api-balance-fetcher.ts:accountper token type (checksum for nativeZERO_ADDRESS, original for ERC20) and propagate viafinalAccount.ProcessedBalance.accounttoChecksumAddress | string.TokenBalancesController.ts:state.tokenBalancesusingaccount as ChecksumAddressto handle mixed address formats during updates.CHANGELOG.md: Add "Fixed" note about address format compatibility betweenTokenBalancesControllerandAccountTrackerControllerinAccountsApiBalanceFetcher.Written by Cursor Bugbot for commit 29bd9b8. This will update automatically on new commits. Configure here.