fix: shield: Make start and stop idempotent #6817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently calling
ShieldController.startrepeatedly will create several event subscriptions.This PR proposes to make
startandstopidempotent, so that callingstartwon't have an effect if the controller is already started, and the same forstop, respectively.References
Checklist
Note
Make
ShieldController.start/stopidempotent; update tests and changelog.start()/stop()idempotent insrc/ShieldController.tsby adding#startedflag and guarding subscribe/unsubscribe.ShieldController.test.tsto usesetupCoverageResultReceivedand add a test ensuring repeatedstart()/stop()calls are tolerated.CHANGELOG.md.Written by Cursor Bugbot for commit 457c056. This will update automatically on new commits. Configure here.