Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Oct 13, 2025

Explanation

Fixes signature coverage result endpoint.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Routes coverage result polling to the correct transaction/signature endpoints and refactors polling to accept a configurable result URL with optional timeout/interval.

  • Shield Controller (packages/shield-controller)
    • Backend (src/backend.ts):
      • Update checkCoverage and checkSignatureCoverage to pass specific result URLs: v1/transaction/coverage/result and v1/signature/coverage/result.
      • Refactor #getCoverageResult to accept a configs object with coverageResultUrl (required) and optional timeout/pollInterval; use provided URL instead of hardcoded path.
    • Changelog:
      • Add Fixed entry for incorrect signature coverage result endpoint.

Written by Cursor Bugbot for commit 9d5c24a. This will update automatically on new commits. Configure here.

@lwin-kyaw lwin-kyaw requested a review from a team as a code owner October 13, 2025 09:25
chaitanyapotti
chaitanyapotti previously approved these changes Oct 13, 2025
@lwin-kyaw
Copy link
Contributor Author

@metamaskbot publish-preview

@chaitanyapotti chaitanyapotti merged commit 6376450 into main Oct 13, 2025
244 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/shield-sig-coverage branch October 13, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants